[cmake-developers] -GNinja on Windows

Bill Hoffman bill.hoffman at kitware.com
Tue Jun 12 13:59:08 EDT 2012


On 6/12/2012 1:44 PM, Peter Kümmel wrote:
>
> I found a much simpler patch:
>
> https://github.com/syntheticpp/ninja/commit/0ea34053a4692f190b8c13ce0ff032a57cece047
>
>
> Could you please have a look at it before I create a merge request?

I would change RemoveQuotes to only remove them if they are at the start 
and end of the string.

Something like this:

if(str.size() == 0)
   return str;
if (str[0] == '\"' && str[str.size()-1] == '\"')
   {
   cleaned = str.substr(1, str.size()-2);
   return cleaned;
   }
return str;


-Bill



More information about the cmake-developers mailing list