[cmake-developers] Global flags for creating static libraries

Brad King brad.king at kitware.com
Tue Dec 11 08:44:08 EST 2012


On 12/10/2012 05:45 PM, Evan Pipho wrote:
> I am nearly finished with this, just need to write the variable documentation and test the xcode generators. 

Thanks for working on this.

> I have committed everything so far to my github fork at 
>  https://github.com/hiwrac/CMake/commits/static_linker_flags 

We can fetch your topic from there so there is no need for a
separate submission.

I just took a quick look.  Here are some comments.

(1) Please arrange your commits to do cleanup and rearrangement
    changes first, and then real changes in separate commits.
    Currently both are mixed together so it is hard to see what
    happened to existing functionality (like target properties).

(2) GetRequiredDefinition is too strict for this.  We do not
    actually need to have a definition of these variables to
    produce a valid build system.  Use plain GetDefinition
    and simply skip the feature if it returns NULL.

Please rewrite your topic to address these and then post back
here so we can take another look.

Thanks!
-Brad



More information about the cmake-developers mailing list