[cmake-developers] ninja status

Peter Kümmel syntheticpp at gmx.net
Sun Apr 8 05:18:53 EDT 2012

On 08.04.2012 01:53, Bill Hoffman wrote:
> On 4/7/2012 5:03 PM, Peter Collingbourne wrote:
>> On Sat, Apr 07, 2012 at 10:00:41PM +0200, Peter Kümmel wrote:
>>> On 07.04.2012 21:56, Peter Kümmel wrote:
>>>> By default Ninja support is not enabled on Windows and Mac, somehow it was build
>>>> the last times but I touched the cmake code there and introduced a FORCE:
>>>> http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=f93e81858b5e1243714ed7f26aadfc791a7b0ff0
>>> I wonder how Ninja was enabled on the build server? Manually by editing CMakeCache.txt?
>> I believe they just use -DCMAKE_ENABLE_NINJA=ON.  I don't see why
>> your change is necessary at all, please revert it.
>> Thanks,
> Yes, please reverse the change.  We want ninja off on Mac and Windows by
> default until all of the tests are passing.

I know ninja should not be enabled on other platforms than Linux, and it wasn't,
even with my patch. This was not a try the enable ninja through the backdoor!

I've fixed it and changed the message so it could not happen again:

> -DCMAKE_ENABLE_NINJA=ON will work, or you can put it in the
> CMakeCache.txt with a dashboard script.

Sorry, I though CMAKE_ENABLE_NINJA would be overwritten on each cmake run.

> Thanks.
> -Bill
> --
> Powered by www.kitware.com
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
> Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

More information about the cmake-developers mailing list