[cmake-developers] [PATCH] Tell people that link_directories() is not what they are searching for

[Rolf Eike Beer]

Am Mittwoch 26 Oktober 2011, 15:14:22 schrieb Brad King:
> On 10/26/2011 2:47 PM, Rolf Eike Beer wrote:
> >  From 7c31000a1e52d3855f6f5162645a126daafd5105 Mon Sep 17 00:00:00 2001
> > 
> > From: Rolf Eike Beer<eike-kernel at sf-tec.de>
> > Date: Wed, 26 Oct 2011 20:43:21 +0200
> > Subject: [PATCH] Tell people that link_directories() is not what they
> > are searching for
> What command are you using to generate this patch?  It does not apply
> correctly with "git am" for me.  I end up manually removing the From: Date:
> and Subject: from the commit message.

git format-patch -1

I copied that into the mail then. Maybe git am got confused when you saved the 
email because those headers were there from both git and the email program? No 
idea.

> > +      "Please note that this command is usually not what you are
> > searching " +      "for. In most cases you do not need to explicitely
> > specify the linker " +      "search path. Just pass the absolute path
> > of your libraries to " +      "target_link_libraries() and let CMake
> > handle the details."
> Good idea.  Perhaps this wording:
> 
>    Note that this command is rarely necessary.  Library locations returned
> by find_package() and find_library() are absolute paths.  Pass these
> absolute library file paths directly to the target_link_libraries()
> command.  CMake will ensure the linker finds them.

I wouldn't object that either. Just wanting to get rid of this questions ;)

Btw.: the HTML help on the webpage is still from 2.8.6.

Eike