[cmake-developers] [PATCH] Tell people that link_directories() is not what they are searching for

Brad King brad.king at kitware.com
Wed Oct 26 15:14:22 EDT 2011


On 10/26/2011 2:47 PM, Rolf Eike Beer wrote:
>  From 7c31000a1e52d3855f6f5162645a126daafd5105 Mon Sep 17 00:00:00 2001
> From: Rolf Eike Beer<eike-kernel at sf-tec.de>
> Date: Wed, 26 Oct 2011 20:43:21 +0200
> Subject: [PATCH] Tell people that link_directories() is not what they are searching for

What command are you using to generate this patch?  It does not apply correctly
with "git am" for me.  I end up manually removing the From: Date: and Subject:
from the commit message.

> +      "Please note that this command is usually not what you are searching "
> +      "for. In most cases you do not need to explicitely specify the linker "
> +      "search path. Just pass the absolute path of your libraries to "
> +      "target_link_libraries() and let CMake handle the details."

Good idea.  Perhaps this wording:

   Note that this command is rarely necessary.  Library locations returned by
   find_package() and find_library() are absolute paths.  Pass these absolute
   library file paths directly to the target_link_libraries() command.  CMake
   will ensure the linker finds them.

?

-Brad



More information about the cmake-developers mailing list