[cmake-developers] install bug on windows

[Eric Noulard]

2010/9/20 Eric Noulard <eric.noulard at gmail.com>:
> 2010/9/20 Bill Hoffman <bill.hoffman at kitware.com>:
>>>
>>>  What do you think?
>>
>> Seems to be covered:
>> (but I am guessing the install is not actually being called in that case...)
>
> Ok then may be I can try to make install called, after
> I found the test which is triggering this coverage.

The only Test which seems to do absolute install on Linux
(which is the platform reported by the coverage report) is:

Tests/CPackComponents/CMakeLists.txt

since it is only done on Unix

if(UNIX AND NOT APPLE)
  if(NOT CPACK_BINARY_NSIS)
    set(mylib_install_to_absolute_path ON)
  endif()
endif()

this does not trigger the bug.

>> BTW, this type of code is not allowed in CMake:
>>
>>   if (fi!=files.begin()) os << ";";
>>
>> Needs to be:
>>
>> if((fi!=files.begin())
>> {
>> os << ";";
>> }
>
> Ok noted.
> WIll fix this too.

I pushed a working fix to stage "fixAbsoluteDestHandlingRegression"
including the CMake coding standard wrt to if {}.

I did NOT request the merge to next.
I'll wait until I'll try to craft the corresponding new test.

Should be tomorrow or wednesday.

In the meantime if you have any advice for adding a new test,
like a sample test I can copy or any other advices I would be glad
to know.

The fact is I did never add a new Test to CMake :-)

-- 
Erk
Membre de l'April - « promouvoir et défendre le logiciel libre » -
http://www.april.org