[cmake-developers] install bug on windows
Eric Noulard
eric.noulard at gmail.com
Mon Sep 20 17:18:46 EDT 2010
2010/9/20 Bill Hoffman <bill.hoffman at kitware.com>:
>>
>> What do you think?
>
> Seems to be covered:
> (but I am guessing the install is not actually being called in that case...)
Ok then may be I can try to make install called, after
I found the test which is triggering this coverage.
> http://www.cdash.org/CDash/viewCoverageFile.php?buildid=726294&fileid=11009794
> TF 63 if (cmSystemTools::FileIsFullPath(dest.c_str()))
> 54 | 64 {
> 55 | 65 os << "list(APPEND
> CPACK_ABSOLUTE_DESTINATION_FILES\n";
> 56 | 66 os << indent << " \"";
> 57 | 67 for(std::vector<std::string>::const_iterator fi =
> files.begin
> 58 | TF 68 fi != files.end(); ++fi)
> 59 | 69 {
> 60 | -->F 70 if (fi!=files.begin()) os << ";";
> 61 | 71 os << dest <<
> cmSystemTools::ConvertToOutputPath("/
> 62 | -->F 72a if (
> 63 | -->t 72b rename &&
> 64 | -->f 72c *rename)
> 65 | 73 {
> 66 | 74 os << rename;
> 67 | 75 }
> 68 | ...
> 69 | 81 os << "\")\n";
> 70 | 82 }
>
>
> BTW, this type of code is not allowed in CMake:
>
> if (fi!=files.begin()) os << ";";
>
> Needs to be:
>
> if((fi!=files.begin())
> {
> os << ";";
> }
Ok noted.
WIll fix this too.
--
Erk
Membre de l'April - « promouvoir et défendre le logiciel libre » -
http://www.april.org
More information about the cmake-developers
mailing list