[cmake-developers] fphsa capitalization

[Alexander Neundorf]

On Tuesday 10 August 2010, Brad King wrote:
> On 08/07/2010 05:25 PM, Alexander Neundorf wrote:
> > diff --git a/Modules/FindSubversion.cmake b/Modules/FindSubversion.cmake
> > index 58a179d..30220d1 100644
> > --- a/Modules/FindSubversion.cmake
> > +++ b/Modules/FindSubversion.cmake
> > @@ -2,7 +2,12 @@
> >  # The module defines the following variables:
> >  #  Subversion_SVN_EXECUTABLE - path to svn command line client
> >  #  Subversion_VERSION_SVN - version of svn command line client
> > -#  Subversion_FOUND - true if the command line client was found
> > +#  SUBVERSION_FOUND - true if the command line client was found
> > +#  Subversion_FOUND - same as SUBVERSION_FOUND, kept around for
> > compatibility
>
> IMO the preferred capitalization is "Subversion_FOUND".
> All the other variables use that.  IIRC your standard
> macro set the value with upper-case because that was
> what many packages did at the time.

I think it is still true for most find-modules, I think there are only a few 
exceptions, mostly Boost and Subversion.
Checking... ok, also PostgreSQL, LibArchive (they are both new, right ?), 
ImageMagick and Java set the exact-case _FOUND variables.
All others (more then 100 ?) use the UPPERCASE_FOUND.

No matter which version I personally like better, I really do think that the 
big majority uses UPPERCASE_CASE found, and now declaring that 
ExactCase_FOUND is the standard would be wrong.

Alex