[cmake-developers] fphsa capitalization

[Eric Noulard]

2010/8/10 Mathieu Malaterre <mathieu.malaterre at gmail.com>:
> On Tue, Aug 10, 2010 at 8:42 PM, Brad King <brad.king at kitware.com> wrote:
>> On 08/07/2010 05:25 PM, Alexander Neundorf wrote:

>>
>>  find_package(Subversion)
>>
>> I would expect to write
>>
>>  if(Subversion_FOUND)
>>     ... ${Subversion_SVN_EXECUTABLE} ...
>>  endif()
>>
>> and not the inconsistent
>>
>>  if(SUBVERSION_FOUND)
>>     ... ${Subversion_SVN_EXECUTABLE} ...
>>  endif()
>>
>> Thoughts?
>
> +1
>
> This has always bitten me in the past. For instance:
>
> find_package(LibXml2)
> message(${(LIBXML2_LIBRARIES})

+1 for me too.
Same reason.


> I would really like to see an automated test which check this in the
> cmake modules.
>
> On a related note, could we use strcasecmp for :
>
> cmake --help-module FindLibXml2
>
> I could never get the case right...

<advertisement type="free">
That's one of the reason I wrote bash completion for CMake :-)

cmake --help-mo<TAB>

gives you
cmake --help-module

then

cmake --help-module FindL<TAB>

gives you only 7 completions :-)

give it a try:
the latest file is here
http://www.cmake.org/pipermail/cmake/attachments/20100728/a45949d0/attachment-0001.obj
the install instructions are here:
http://www.cmake.org/pipermail/cmake/2010-July/038442.html
</advertisement>

However case insensitive tolerance is a good idea too.

-- 
Erk
Membre de l'April - « promouvoir et défendre le logiciel libre » -
http://www.april.org