View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0007318CMakeModulespublic2008-07-09 12:272016-06-10 14:30
ReporterMatt Leotta 
Assigned ToKitware Robot 
PlatformOSOS Version
Product VersionCMake-2-6 
Target VersionFixed in Version 
Summary0007318: Request for addition of FindDC1394.cmake module
DescriptionThis module has been used in VXL for finding libdc1394 version 2. This library provides drivers for IEEE 1394 (firewire) digital cameras conforming to the IIDC specs. The code runs on Linux, OS X, and will run on Windows in the future. [^]
Additional InformationAttached is the module currently in use with VXL. It may or may not fully meet the standards for writing CMake modules, but it does work in Linux and OS X.

This module is for finding version 2 of the code, version 2 is incompatible with version 1 so maybe it should be FindDC1394-2.cmake or something like that? I'm not sure about your naming conventions.

I am willing to become a maintainer for this module if necessary.
TagsNo tags attached.
Attached Files? file icon FindDC1394.cmake [^] (762 bytes) 2008-07-09 12:27
? file icon FindDC1394.patch1 [^] (1,171 bytes) 2008-07-21 16:46


Alex Neundorf (developer)
2008-07-21 13:04


thanks a lot for the file, here are some comments:

You don't need to list these directories, they are in the default set of search directories (see Modules/Platform/UnixPaths.cmake)

Also it would be nice if you would use the macro FIND_PACKAGE_HANDLE_STANDARD_ARGS() from the FindPackageHandleStandardArgs.cmake file. Can you post a modified patch and make sure it works with cmake 2.6 ?

Matt Leotta (developer)
2008-07-21 16:50


Thanks for the advice. I've posted the patch. It works with cmake 2.6 (for me). I'll patch the other modules I've recently submitted in a similar way, but I'll be away for a week so it might not get done right away.

Matt Leotta (developer)
2008-10-13 12:41

I've just discovered that dc1394 has some additional framework dependencies on Mac OS X. The module should probably also contain something like the following:

# Find Apple Framework dependencies
                       "-framework CoreFoundation"
                       "-framework IOKit" )

Also, I am a module developer now, so if you want me to handle this just have this issue reassigned to me.
Enrique Fdez (reporter)
2010-08-24 17:12

Actually, the code above doesn't work in Mac OS X 10.6. You only need CoreServices framework, not the other two. See comment here: [^]

I've tested it and works perfectly. This is the cmake code:
# Find Apple Framework dependencies
                       "-framework CoreServices" )

Not sure what happens in other version of OS X.
I hope this information will be useful and I'd like that cmake includes one FindDC1394.cmake or similar.
Thanks for your work and comments.
Alex Neundorf (developer)
2011-03-10 15:28

In order to get this into cmake, somebody, e.g. you, need to volunteer to maintain it in cmake: [^]

Enrique Fdez (reporter)
2011-03-11 14:18

If there's enough interest, I'll try to maintain this module.

Alex Neundorf (developer)
2011-03-12 14:53

Sounds good :-)
So please follow the steps described here: [^]

You'll get git push access then etc.

Alex Neundorf (developer)
2012-01-04 16:05

So, as written above, please follow the steps as described here: [^]

This way you'll become the maintainer of this module in cmake.

I won't add it myself, because I'm not using it. So I'm unassigning it from me.

Kitware Robot (administrator)
2016-06-10 14:27

Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

 Issue History
Date Modified Username Field Change
2008-07-09 12:27 Matt Leotta New Issue
2008-07-09 12:27 Matt Leotta File Added: FindDC1394.cmake
2008-07-21 13:04 Alex Neundorf Note Added: 0012774
2008-07-21 16:46 Matt Leotta File Added: FindDC1394.patch1
2008-07-21 16:50 Matt Leotta Note Added: 0012781
2008-08-19 16:50 Bill Hoffman Status new => assigned
2008-08-19 16:50 Bill Hoffman Assigned To => Alex Neundorf
2008-10-13 12:41 Matt Leotta Note Added: 0013861
2010-08-24 17:12 Enrique Fdez Note Added: 0021935
2011-03-10 15:28 Alex Neundorf Note Added: 0025748
2011-03-11 14:18 Enrique Fdez Note Added: 0025761
2011-03-12 14:53 Alex Neundorf Note Added: 0025764
2012-01-04 16:05 Alex Neundorf Note Added: 0028175
2012-01-04 16:05 Alex Neundorf Assigned To Alex Neundorf =>
2012-01-04 16:05 Alex Neundorf Status assigned => backlog
2016-06-10 14:27 Kitware Robot Note Added: 0041440
2016-06-10 14:27 Kitware Robot Status backlog => resolved
2016-06-10 14:27 Kitware Robot Resolution open => moved
2016-06-10 14:27 Kitware Robot Assigned To => Kitware Robot
2016-06-10 14:30 Kitware Robot Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team