View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0005551

CMake

public

2007-08-21 11:31

2016-06-10 14:30

Reporter

Sebastian Hauer

Assigned To

Bill Hoffman

Priority

normal

Severity

feature

Reproducibility

always

Status

closed

Resolution

moved

Platform

x86

Windows

OS Version

Product Version

Target Version

Fixed in Version

Summary

0005551: New VisualStudio 7 linker setting in project file: SuppressStartupBanner

Description

I wanted to have the option to turn off the default /nologo flag for both the Visual Studio compiler and linker. Enabling CMAKE_VERBOSE_MAKEFILE took care of the compiler but not the linker. I noticed that CMAKE_VERBOSE_MAKEFILE would set SuppressStartupBanner under <Tool Name="VCCLCompilerTool" .. /> in the generated .vcproj file but not under <Tool Name="VCLinkerTool" .. />.

I've added a new SuppressStartupBanner option to cmLocalVisualStudio7GeneratorLinkFlagTable and modified cmLocalVisualStudio7Generator::OutputBuildTool() to check for the value of CMAKE_VERBOSE_MAKEFILE.

I've tested it on my local box and it works. Please see the attached unified diff patch for the modifications.

Tags

No tags attached.

Attached Files

cmake-Linker-SuppressStartupBanner.patch [^] (986 bytes) 2007-08-21 11:31 [Show Content] [Hide Content]

--- cmake-2.4.7\Source\cmLocalVisualStudio7Generator.cxx	2007-07-16 17:16:44.000000000 -0400
+++ cmake-2.4.7-sh\Source\cmLocalVisualStudio7Generator.cxx	2007-08-21 10:34:48.250000000 -0400
@@ -384,6 +384,7 @@
   {"GenerateManifest", "MANIFEST", "enable manifest generation", "TRUE", 0},
   {"LinkIncremental", "INCREMENTAL:NO", "link incremental", "1", 0},
   {"LinkIncremental", "INCREMENTAL:YES", "link incremental", "2", 0},
+  {"SuppressStartupBanner", "nologo", "SuppressStartupBanner", "TRUE", 0},
   {"IgnoreDefaultLibraryNames", "NODEFAULTLIB:", "default libs to ignore", "",
    cmVS7FlagTable::UserValue},
   {"IgnoreAllDefaultLibraries", "NODEFAULTLIB", "ignore all default libs",
@@ -733,6 +734,9 @@
     }
   Options linkOptions(Options::Linker);
   linkOptions.Parse(extraLinkOptions.c_str());
+  linkOptions.SetVerboseMakefile(
+    this->Makefile->IsOn("CMAKE_VERBOSE_MAKEFILE"));
+
   switch(target.GetType())
     {
     case cmTarget::STATIC_LIBRARY:

Relationships

Notes
(0041381) Kitware Robot (administrator) 2016-06-10 14:27	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2007-08-21 11:31	Sebastian Hauer	New Issue
2007-08-21 11:31	Sebastian Hauer	File Added: cmake-Linker-SuppressStartupBanner.patch
2007-12-17 21:25	Bill Hoffman	Status	new => assigned
2007-12-17 21:25	Bill Hoffman	Assigned To	=> Bill Hoffman
2011-01-26 11:26	David Cole	Category	=> CMake
2016-06-10 14:27	Kitware Robot	Note Added: 0041381
2016-06-10 14:27	Kitware Robot	Status	assigned => resolved
2016-06-10 14:27	Kitware Robot	Resolution	open => moved
2016-06-10 14:30	Kitware Robot	Status	resolved => closed