View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0015485

CMake

public

2015-03-31 12:07

2016-06-10 14:31

Reporter

Daniel Dunbar

Assigned To

Kitware Robot

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

moved

Platform

OS X

OS Version

Product Version

Target Version

Fixed in Version

Summary

0015485: CFBundleExecutable path in a bundle should not be a relative path into bundle

Description

The CFBundleExecutable path inside of a CMake generated bundle is a relative path including the bundle name itself. This is not correct, it should simply be the name of the bundle binary that is inside the MacOS directory:

In this example:
--
$ cat CMakeLists.txt
cmake_minimum_required(VERSION 3.2)
add_library(Bar MODULE Bar.c)
set_target_properties(Bar PROPERTIES BUNDLE true)
$ touch Bar.c
$ cmake -G Ninja .
...
$ ninja
[1/2] Building C object CMakeFiles/Bar.dir/Bar.c.o
[2/2] Linking C CFBundle shared module Bar.bundle/Contents/MacOS/Bar
$ defaults read $(pwd)/Bar.bundle/Contents/Info.plist CFBundleExecutable
Bar.bundle/Contents/MacOS/Bar
$
--
the last line should just print "Bar".

You can verify this is not what the platform expects by trying to load the bundle from somewhere else:
--
$ cat load.m
#import <Foundation/Foundation.h>

int main(int argc, char **argv) {
    @autoreleasepool {
        NSBundle *bundle = [NSBundle bundleWithPath:[[NSString alloc] initWithUTF8String:argv[1]]];
        [bundle load];
    }
    return 0;
}
$ clang load.m -o load -framework Foundation && ./load Bar.bundle
2015-03-31 09:07:24.778 load[95727:5952049] Cannot find executable for CFBundle 0x7fc292d13ac0 </private/tmp/bar/Bar.bundle> (not loaded)
--
whereas this will load fine if the CFBundleExecutable key is just "Bar".

Tags

No tags attached.

Attached Files

0001-Show-only-bundle-name-in-Xcode.patch [^] (969 bytes) 2015-04-01 16:28 [Show Content] [Hide Content]

From c1f942e04e0a06b874b28b9367f8455c353c3e33 Mon Sep 17 00:00:00 2001
From: Gregor Jasny <gjasny@googlemail.com>
Date: Sat, 13 Dec 2014 18:01:54 +0100
Subject: [PATCH] Show only bundle name in Xcode

---
 Source/cmGlobalXCodeGenerator.cxx | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Source/cmGlobalXCodeGenerator.cxx b/Source/cmGlobalXCodeGenerator.cxx
index de6e915..9ce7c64 100644
--- a/Source/cmGlobalXCodeGenerator.cxx
+++ b/Source/cmGlobalXCodeGenerator.cxx
@@ -2611,6 +2611,12 @@ cmGlobalXCodeGenerator::CreateXCodeTarget(cmTarget& cmtarget,
   else
     {
     fullName = cmtarget.GetFullName(defConfig.c_str());
+    if(cmtarget.IsCFBundleOnApple())
+      {
+      std::size_t pos = fullName.find('/');
+      if(pos != std::string::npos)
+        fullName = fullName.substr(0, pos);
+      }
     }
   fileRef->AddAttribute("path", this->CreateString(fullName.c_str()));
   fileRef->AddAttribute("refType", this->CreateString("0"));
-- 
2.3.3

Relationships

Notes
(0038372) Brad King (manager) 2015-03-31 13:30	The GenerateAppleInfoPList method: http://www.cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmLocalGenerator.cxx;hb=v3.2.1#l3698 [^] uses its targetName parameter as the value for CFBundleExecutable in the Info.plist file. The value of that parameter is correct for application bundles. It may need a special case for CFBundles because the value of targetName comes from cmTarget::GetFullNameInternal: http://www.cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmTarget.cxx;hb=v3.2.1#l3928 [^] which has a special case for CFBundles here: http://www.cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmTarget.cxx;hb=v3.2.1#l4027 [^]

(0038373) Brad King (manager) 2015-03-31 13:31	Nicolas?

(0038385) Gregor Jasny (developer) 2015-04-01 16:28 edited on: 2015-04-01 16:29	Same for the product name visible in Xcode. Patch attached. Maybe one can find a general solution.

(0038388) Brad King (manager) 2015-04-01 16:36	Re 0015485:0038385: I think there can be more than one slash. Ideally some refactoring would be done to allow the proper name to be extracted anywhere it is needed.

(0042746) Kitware Robot (administrator) 2016-06-10 14:29	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2015-03-31 12:07	Daniel Dunbar	New Issue
2015-03-31 13:30	Brad King	Note Added: 0038372
2015-03-31 13:31	Brad King	Note Added: 0038373
2015-04-01 16:28	Gregor Jasny	Note Added: 0038385
2015-04-01 16:28	Gregor Jasny	File Added: 0001-Show-only-bundle-name-in-Xcode.patch
2015-04-01 16:29	Gregor Jasny	Note Edited: 0038385
2015-04-01 16:36	Brad King	Note Added: 0038388
2016-06-10 14:29	Kitware Robot	Note Added: 0042746
2016-06-10 14:29	Kitware Robot	Status	new => resolved
2016-06-10 14:29	Kitware Robot	Resolution	open => moved
2016-06-10 14:29	Kitware Robot	Assigned To	=> Kitware Robot
2016-06-10 14:31	Kitware Robot	Status	resolved => closed