View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0015461

CMake

public

2015-03-20 15:37

2016-06-10 14:31

Reporter

Chris Green

Assigned To

Kitware Robot

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

moved

Platform

x86-64

OS X

OS Version

10.10.2

Product Version

CMake 3.2.1

Target Version

Fixed in Version

Summary

0015461: Ninja generator does not honor COMMENT for TARGET POST_BUILD commands

Description

Upon adding a TARGET POST_BUILD command to make an alias link for a built library, the Ninja system does not print my defined COMMENT.

Steps To Reproduce

Define a custom command as a POST_BUILD command to (e.g.) a library target, and define a COMMENT.

Run CMake -GNinja.

Run ninja > log.txt 2>&1

Fail to see your COMMENT in log.txt.

Additional Information

The COMMENT is printed as expected with the UNIX Makefile generator in CMake 3.2.1.

The actual command we used:

function(cet_lib_alias LIB_TARGET)
  foreach(alias ${ARGN})
    add_custom_command(TARGET ${LIB_TARGET}
      POST_BUILD
      COMMAND ln -sf $<TARGET_LINKER_FILE_NAME:${LIB_TARGET}>
      ${CMAKE_SHARED_LIBRARY_PREFIX}${alias}${CMAKE_SHARED_LIBRARY_SUFFIX}
      COMMENT "Generate / refresh courtesy link ${CMAKE_SHARED_LIBRARY_PREFIX}${alias}${CMAKE_SHARED_LIBRARY_SUFFIX} -> $<TARGET_LINKER_FILE_NAME:${LIB_TARGET}>"
      VERBATIM
      WORKING_DIRECTORY ${LIBRARY_OUTPUT_PATH})
  endforeach()
endfunction()

Tags

No tags attached.

Attached Files

Relationships

Notes
(0042737) Kitware Robot (administrator) 2016-06-10 14:29	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2015-03-20 15:37	Chris Green	New Issue
2016-06-10 14:29	Kitware Robot	Note Added: 0042737
2016-06-10 14:29	Kitware Robot	Status	new => resolved
2016-06-10 14:29	Kitware Robot	Resolution	open => moved
2016-06-10 14:29	Kitware Robot	Assigned To	=> Kitware Robot
2016-06-10 14:31	Kitware Robot	Status	resolved => closed