View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0015428 | CMake | CMake | public | 2015-03-02 14:29 | 2015-11-02 09:13 | ||||
Reporter | johan andruejol | ||||||||
Assigned To | Brad King | ||||||||
Priority | normal | Severity | major | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | CMake 3.1.3 | ||||||||
Target Version | CMake 3.3 | Fixed in Version | CMake 3.3 | ||||||
Summary | 0015428: InstallRequiredSystemLibraries.cmake does not work when installing with component | ||||||||
Description | The libraries found with the InstallRequiredSystemLibraries.cmake always have the "Unspecified" component since no component is specified. This makes project that package with the component option (CPACK_INSTALL_CMAKE_PROJECTS) not install those libraries. I included a patch that could be a solution to this problem. | ||||||||
Steps To Reproduce | For example, Slicer as of https://github.com/Slicer/Slicer/commit/454fed0f5f2f8ea18269f2bfdfc4733326c4c6d7 [^] does not package the windows redistributable libraries. (See also download.slicer.org/bitstream/325826) | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | 0001-Modules-Add-component-option-for-InstallRequiredSyst.patch [^] (2,213 bytes) 2015-03-02 14:29 [Show Content] | ||||||||
Relationships | |
Relationships |
Notes | |
(0038142) Brad King (manager) 2015-03-03 09:21 |
First I took this opportunity to format the documentation better: InstallRequiredSystemLibraries: Format documentation http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d6a320ab [^] Then I applied your change with some refactoring: InstallRequiredSystemLibraries: Add option to specify install COMPONENT http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e97141c2 [^] |
(0038143) Brad King (manager) 2015-03-03 09:23 |
Meanwhile Slicer can use CMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP to disable the automatic install(PROGRAMS) rule and make its own call with the COMPONENT to work with older CMake versions. |
(0038144) johan andruejol (reporter) 2015-03-03 09:28 |
Great ! Thanks for your help ! |
(0039722) Robert Maynard (manager) 2015-11-02 09:13 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2015-03-02 14:29 | johan andruejol | New Issue | |
2015-03-02 14:29 | johan andruejol | File Added: 0001-Modules-Add-component-option-for-InstallRequiredSyst.patch | |
2015-03-03 09:21 | Brad King | Note Added: 0038142 | |
2015-03-03 09:23 | Brad King | Note Added: 0038143 | |
2015-03-03 09:23 | Brad King | Assigned To | => Brad King |
2015-03-03 09:23 | Brad King | Status | new => resolved |
2015-03-03 09:23 | Brad King | Resolution | open => fixed |
2015-03-03 09:23 | Brad King | Fixed in Version | => CMake 3.3 |
2015-03-03 09:23 | Brad King | Target Version | => CMake 3.3 |
2015-03-03 09:28 | johan andruejol | Note Added: 0038144 | |
2015-11-02 09:13 | Robert Maynard | Note Added: 0039722 | |
2015-11-02 09:13 | Robert Maynard | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |