View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0014889 | CMake | CPack | public | 2014-04-18 11:16 | 2014-10-06 10:33 | ||||
Reporter | Nicolas H. | ||||||||
Assigned To | Nils Gladitz | ||||||||
Priority | normal | Severity | crash | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | x86_64 | OS | windows | OS Version | all | ||||
Product Version | |||||||||
Target Version | CMake 3.1 | Fixed in Version | CMake 3.1 | ||||||
Summary | 0014889: Cpack crashes when issuing a bad Wix Patch | ||||||||
Description | i'm trying to patch a wix script with a bad xml id | ||||||||
Steps To Reproduce | reproduced on master (patch only implemented in cmake 3) add SET(CPACK_WIX_PATCH_FILE file.xml) to your project issue a bad xml fragment ID (on that wixGenerator cannot find) cpack crash | ||||||||
Additional Information | there is an issue when creating cmCPackWIXGenerator object. Patch object is not defined, so a null pointer is passed at construction time. I've fixed it, patch is attached | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | 0001-fixed-cpack-wix-patch-issue-due-to-bad-logger-initia.patch [^] (4,705 bytes) 2014-04-18 11:16 [Show Content] | ||||||||
Relationships | |
Relationships |
Notes | |
(0035755) Brad King (manager) 2014-04-21 14:04 |
The offending code appears to be introduced in post-3.0 development here: CPackWIX: refactor and cleanup http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6fcd835c [^] Does the recent commit: CPackWIX: Delay creation of cmWIXPatch until CPack has initialized Logger http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cb59f5da [^] resolve this? |
(0035758) Nils Gladitz (developer) 2014-04-21 14:43 |
Yes, the issue does not manifest in v3.0.0-rc4. The commit fixes it for master. Thanks for the report! |
(0036982) Robert Maynard (manager) 2014-10-06 10:33 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2014-04-18 11:16 | Nicolas H. | New Issue | |
2014-04-18 11:16 | Nicolas H. | File Added: 0001-fixed-cpack-wix-patch-issue-due-to-bad-logger-initia.patch | |
2014-04-18 11:19 | Brad King | Assigned To | => Nils Gladitz |
2014-04-18 11:19 | Brad King | Status | new => assigned |
2014-04-21 14:04 | Brad King | Note Added: 0035755 | |
2014-04-21 14:04 | Brad King | Product Version | CMake 2.8.12.2 => |
2014-04-21 14:04 | Brad King | Target Version | => CMake 3.1 |
2014-04-21 14:43 | Nils Gladitz | Note Added: 0035758 | |
2014-04-21 14:43 | Nils Gladitz | Status | assigned => resolved |
2014-04-21 14:43 | Nils Gladitz | Resolution | open => fixed |
2014-04-22 08:33 | Brad King | Fixed in Version | => CMake 3.1 |
2014-10-06 10:33 | Robert Maynard | Note Added: 0036982 | |
2014-10-06 10:33 | Robert Maynard | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |