View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014656CMakeModulespublic2013-12-18 17:442015-01-05 08:39
ReporterNicolas Bock 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 2.8.11.2 
Target VersionCMake 3.1Fixed in VersionCMake 3.1 
Summary0014656: FindOpenMP does not return Fortran flags
DescriptionThe FindOpenMP modules assumes C/C++ code. For a pure Fortran project this is not very useful, as the C/C++ compiler flags don't always translate, or are not determinable because only a Fortran frontend of the compiler is installed. Ideally the module checks for OpenMP flags only for the languages the project is configured for.
TagsNo tags attached.
Attached Files? file icon FindOpenMP.cmake [^] (6,715 bytes) 2014-08-06 10:08
? file icon CheckFortranSourceCompiles.cmake [^] (3,586 bytes) 2014-08-06 10:08
patch file icon ebd8fa22+0001-Add-CheckFortranSourceCompiles-module-14656.patch [^] (7,137 bytes) 2014-08-06 10:59 [Show Content]
patch file icon ebd8fa22+0002-FindOpenMP-Add-support-for-Fortran-14656.patch [^] (3,172 bytes) 2014-08-06 10:59 [Show Content]

 Relationships

  Notes
(0036561)
Nicolas Bock (reporter)
2014-08-06 10:09

I have modified the existing (2.8.12.2) version of FindOpenMP.cmake to include a test for Fortran compilers. In addition I have modified the existing CheckCSourceCompiles.cmake to compile Fortran code. Could you look over the two attached scripts?

Thanks
(0036563)
Brad King (manager)
2014-08-06 11:00

Re 0014656:0036561: Thanks. Based on those I constructed patches

 ebd8fa22+0001-Add-CheckFortranSourceCompiles-module-14656.patch
 ebd8fa22+0002-FindOpenMP-Add-support-for-Fortran-14656.patch

They are based on the Git 'master' version of CMake as of commit ebd8fa22. Please try it out.
(0036634)
Brad King (manager)
2014-08-18 11:22

The first patch has been applied:

 Add CheckFortranSourceCompiles module
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7386d0d6 [^]
(0036644)
Brad King (manager)
2014-08-19 09:47

The second patch has been applied:

 FindOpenMP: Add support for Fortran
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d0678408 [^]
(0037619)
Robert Maynard (manager)
2015-01-05 08:39

Closing resolved issues that have not been updated in more than 4 months

 Issue History
Date Modified Username Field Change
2013-12-18 17:44 Nicolas Bock New Issue
2014-08-06 10:08 Nicolas Bock File Added: FindOpenMP.cmake
2014-08-06 10:08 Nicolas Bock File Added: CheckFortranSourceCompiles.cmake
2014-08-06 10:09 Nicolas Bock Note Added: 0036561
2014-08-06 10:59 Brad King File Added: ebd8fa22+0001-Add-CheckFortranSourceCompiles-module-14656.patch
2014-08-06 10:59 Brad King File Added: ebd8fa22+0002-FindOpenMP-Add-support-for-Fortran-14656.patch
2014-08-06 11:00 Brad King Note Added: 0036563
2014-08-18 11:22 Brad King Note Added: 0036634
2014-08-19 09:47 Brad King Note Added: 0036644
2014-08-19 09:47 Brad King Assigned To => Brad King
2014-08-19 09:47 Brad King Status new => assigned
2014-08-19 09:47 Brad King Target Version => CMake 3.1
2014-08-20 09:23 Michael Klemm (Intel) Note Added: 0036654
2014-08-20 09:24 Michael Klemm (Intel) Note Deleted: 0036654
2014-08-21 10:36 Brad King Status assigned => resolved
2014-08-21 10:36 Brad King Resolution open => fixed
2014-08-21 10:36 Brad King Fixed in Version => CMake 3.1
2015-01-05 08:39 Robert Maynard Note Added: 0037619
2015-01-05 08:39 Robert Maynard Status resolved => closed


Copyright © 2000 - 2018 MantisBT Team