View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0014436

CMake

public

2013-09-24 10:21

2014-03-05 09:58

Reporter

mar-na

Assigned To

Patrick R. Gansterer

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

CMake 2.8.12

Fixed in Version

CMake 2.8.12

Summary

0014436: Missing ARCHFAM preprocessor definition in WinCE Visual Studio generators (armv41)

Description

I try to compile a HelloWorld console application for WinCE STANDARDSDK_500 (ARMV41) with VS 2008.

In CMake 2.8.11 it works but in 2.8.11.20130923 failed it with strange compiler error:

(compiler log from VS 2008)
Compiling...
HelloWorld.cpp
C:\Programme\Windows CE Tools\wce500\STANDARDSDK_500\include\ARMV4I\winnt.h(2975) : error C2146: syntax error : missing ';' before identifier 'ContextRecord'
C:\Programme\Windows CE Tools\wce500\STANDARDSDK_500\include\ARMV4I\winnt.h(2975) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
C:\Programme\Windows CE Tools\wce500\STANDARDSDK_500\include\ARMV4I\winnt.h(2975) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int

I compare the generated project files and found that in the CMake trunk are the preprocessor definition for ARCHFAM is missing.
If I manuelle added $(ARCHFAM);$(_ARCHFAM_) or ARM;_ARM_ than it worked.

Steps To Reproduce

Use "Visual Studio 9 2008 STANDARDSDK_500 (ARMV41)" generator.
ARCHFAM is missing in preprocessor definition. e.g. for ARMV41 ARM;_ARM_.
Or alternativly (as Visual Studio 'native' do it) $(ARCHFAM);$(_ARCHFAM_)

cmake 2.8.11 STANDARDSDK_500 (ARMV41)
-------------------------------------
_WIN32_WCE=0x500
UNDER_CE
ARM
_ARM_
_WINDOWS
_DEBUG
CMAKE_INTDIR=\"Debug\"

cmake 2.8.11.20130923 STANDARDSDK_500 (ARMV41)
----------------------------------------------

_WIN32_WCE=0x500
UNDER_CE
THUMB
_THUMB_
_WINDOWS
_DEBUG
CMAKE_INTDIR=\"Debug\"

-> is THUMB and _THUMB_ here right? $(ARCHFAM);$(_ARCHFAM_) or ARM;_ARM_ is missing

for comparison only:
If the "Visual Studio 9 2008 STANDARDSDK_500 (x86)" generator is used it works

cmake 2.8.11.20130923 STANDARDSDK_500 (x86)
------------------------

_WIN32_WCE=0x500
UNDER_CE
X86
_X86_
_WINDOWS
_DEBUG
CMAKE_INTDIR=\"Debug\"

Additional Information

If a project is generate with the VS than the preprocessor definition are set to this:

'native' generated with VS 2008
-------------------------------
DEBUG
_WIN32_WCE=$(CEVER)
UNDER_CE
WINCE
DEBUG
_CONSOLE
$(ARCHFAM)
$(_ARCHFAM_)

Tags

No tags attached.

Attached Files

0001-MSVC-Fix-WinCE-arch-family-preprocessor-symbol-for-A.patch [^] (2,429 bytes) 2013-09-24 11:45 [Show Content] [Hide Content]

From 3fa22bf1193a48654e4961e4f01a0027dd2cf731 Mon Sep 17 00:00:00 2001
Message-Id: <3fa22bf1193a48654e4961e4f01a0027dd2cf731.1380037321.git.brad.king@kitware.com>
From: Brad King <brad.king@kitware.com>
Date: Tue, 24 Sep 2013 11:35:49 -0400
Subject: [PATCH] MSVC: Fix WinCE arch family preprocessor symbol for ARM
 (#14436)

In commit bd827f98 (Use COFF file header header for architecture
detection, 2013-08-05) the MSVC_<lang>_ARCHITECTURE_ID value computed by
CMakeDetermineCompilerId.cmake changed for ARM architectures to be the
exact architecture read from the PE header.  Fix platform preprocessor
definitions in Modules/Platform/Windows-MSVC.cmake to correspond to the
ARM family instead of the specific architecture.
---
 Modules/Platform/Windows-MSVC.cmake | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/Modules/Platform/Windows-MSVC.cmake b/Modules/Platform/Windows-MSVC.cmake
index d9881f2..1daa391 100644
--- a/Modules/Platform/Windows-MSVC.cmake
+++ b/Modules/Platform/Windows-MSVC.cmake
@@ -124,8 +124,14 @@ endif()
 set(CMAKE_BUILD_TYPE_INIT Debug)
 
 if(WINCE)
-  string(TOUPPER "${MSVC_C_ARCHITECTURE_ID}" _MSVC_C_ARCHITECTURE_ID_UPPER)
-  string(TOUPPER "${MSVC_CXX_ARCHITECTURE_ID}" _MSVC_CXX_ARCHITECTURE_ID_UPPER)
+  foreach(lang C CXX)
+    set(_MSVC_${lang}_ARCHITECTURE_FAMILY "${MSVC_${lang}_ARCHITECTURE_ID}")
+    if("${_MSVC_${lang}_ARCHITECTURE_FAMILY}" MATCHES "^(SH|THUMB)")
+      set(_MSVC_${lang}_ARCHITECTURE_FAMILY "ARM")
+    endif()
+  endforeach()
+  string(TOUPPER "${_MSVC_C_ARCHITECTURE_FAMILY}" _MSVC_C_ARCHITECTURE_FAMILY_UPPER)
+  string(TOUPPER "${_MSVC_CXX_ARCHITECTURE_FAMILY}" _MSVC_CXX_ARCHITECTURE_FAMILY_UPPER)
 
   if("${CMAKE_SYSTEM_VERSION}" MATCHES "^([0-9]+)\\.([0-9]+)")
     math(EXPR _CE_VERSION "${CMAKE_MATCH_1}*100 + ${CMAKE_MATCH_2}")
@@ -136,8 +142,8 @@ if(WINCE)
   endif()
 
   set(_PLATFORM_DEFINES "/D_WIN32_WCE=0x${_CE_VERSION} /DUNDER_CE")
-  set(_PLATFORM_DEFINES_C " /D${MSVC_C_ARCHITECTURE_ID} /D_${_MSVC_C_ARCHITECTURE_ID_UPPER}_")
-  set(_PLATFORM_DEFINES_CXX " /D${MSVC_CXX_ARCHITECTURE_ID} /D_${_MSVC_CXX_ARCHITECTURE_ID_UPPER}_")
+  set(_PLATFORM_DEFINES_C " /D${_MSVC_C_ARCHITECTURE_FAMILY} /D_${_MSVC_C_ARCHITECTURE_FAMILY_UPPER}_")
+  set(_PLATFORM_DEFINES_CXX " /D${_MSVC_CXX_ARCHITECTURE_FAMILY} /D_${_MSVC_CXX_ARCHITECTURE_FAMILY_UPPER}_")
 
   set(_RTC1 "")
   set(_FLAGS_CXX " /GR /EHsc")
-- 
1.8.4.rc3

0001-MSVC-Fix-WinCE-arch-family-preprocessor-symbol-14436.patch [^] (2,549 bytes) 2013-09-24 11:53 [Show Content] [Hide Content]

From 53651627c1a9c56f29f7bcb8a203e76e9549bf35 Mon Sep 17 00:00:00 2001
Message-Id: <53651627c1a9c56f29f7bcb8a203e76e9549bf35.1380037859.git.brad.king@kitware.com>
From: Brad King <brad.king@kitware.com>
Date: Tue, 24 Sep 2013 11:35:49 -0400
Subject: [PATCH] MSVC: Fix WinCE arch family preprocessor symbol (#14436)

In commit bd827f98 (Use COFF file header header for architecture
detection, 2013-08-05) the MSVC_<lang>_ARCHITECTURE_ID value computed by
CMakeDetermineCompilerId.cmake changed for WinCE architectures to be the
exact architecture read from the PE header.  Fix platform preprocessor
definitions in Modules/Platform/Windows-MSVC.cmake to correspond to the
architecture family (ARM or SHx) instead of the specific architecture.
---
 Modules/Platform/Windows-MSVC.cmake | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/Modules/Platform/Windows-MSVC.cmake b/Modules/Platform/Windows-MSVC.cmake
index d9881f2..bc53936 100644
--- a/Modules/Platform/Windows-MSVC.cmake
+++ b/Modules/Platform/Windows-MSVC.cmake
@@ -124,8 +124,16 @@ endif()
 set(CMAKE_BUILD_TYPE_INIT Debug)
 
 if(WINCE)
-  string(TOUPPER "${MSVC_C_ARCHITECTURE_ID}" _MSVC_C_ARCHITECTURE_ID_UPPER)
-  string(TOUPPER "${MSVC_CXX_ARCHITECTURE_ID}" _MSVC_CXX_ARCHITECTURE_ID_UPPER)
+  foreach(lang C CXX)
+    set(_MSVC_${lang}_ARCHITECTURE_FAMILY "${MSVC_${lang}_ARCHITECTURE_ID}")
+    if(_MSVC_${lang}_ARCHITECTURE_FAMILY STREQUAL "THUMB")
+      set(_MSVC_${lang}_ARCHITECTURE_FAMILY "ARM")
+    elseif(_MSVC_${lang}_ARCHITECTURE_FAMILY MATCHES "^SH")
+      set(_MSVC_${lang}_ARCHITECTURE_FAMILY "SHx")
+    endif()
+  endforeach()
+  string(TOUPPER "${_MSVC_C_ARCHITECTURE_FAMILY}" _MSVC_C_ARCHITECTURE_FAMILY_UPPER)
+  string(TOUPPER "${_MSVC_CXX_ARCHITECTURE_FAMILY}" _MSVC_CXX_ARCHITECTURE_FAMILY_UPPER)
 
   if("${CMAKE_SYSTEM_VERSION}" MATCHES "^([0-9]+)\\.([0-9]+)")
     math(EXPR _CE_VERSION "${CMAKE_MATCH_1}*100 + ${CMAKE_MATCH_2}")
@@ -136,8 +144,8 @@ if(WINCE)
   endif()
 
   set(_PLATFORM_DEFINES "/D_WIN32_WCE=0x${_CE_VERSION} /DUNDER_CE")
-  set(_PLATFORM_DEFINES_C " /D${MSVC_C_ARCHITECTURE_ID} /D_${_MSVC_C_ARCHITECTURE_ID_UPPER}_")
-  set(_PLATFORM_DEFINES_CXX " /D${MSVC_CXX_ARCHITECTURE_ID} /D_${_MSVC_CXX_ARCHITECTURE_ID_UPPER}_")
+  set(_PLATFORM_DEFINES_C " /D${_MSVC_C_ARCHITECTURE_FAMILY} /D_${_MSVC_C_ARCHITECTURE_FAMILY_UPPER}_")
+  set(_PLATFORM_DEFINES_CXX " /D${_MSVC_CXX_ARCHITECTURE_FAMILY} /D_${_MSVC_CXX_ARCHITECTURE_FAMILY_UPPER}_")
 
   set(_RTC1 "")
   set(_FLAGS_CXX " /GR /EHsc")
-- 
1.8.4.rc3

Relationships

related to	0014420	closed	Patrick R. Gansterer	testCCompiler failed under WinCE with linker error
related to	0014083	closed	Patrick R. Gansterer	WinCE generators should not default to THUMB for ARMV4 SDKs
related to	0014440	closed	Patrick R. Gansterer	Could not generated VS project file for WinCE sh4

Notes
(0033876) mar-na (reporter) 2013-09-24 10:24	in build are the project files which are generated with cmake 2.8.11.20130923 and in build_2-8-11 which are generated with cmake 2.8.11

(0033877) mar-na (reporter) 2013-09-24 10:27	In cmVisualStudioWCEPlatformParser.h is a function cmVisualStudioWCEPlatformParser::GetArchitectureFamily. What do it. Could it used for this? It is currently unused.

(0033880) Brad King (manager) 2013-09-24 11:17	This regression was caused by: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bd827f98 [^] because it changes the MSVC_<lang>_ARCHITECTURE_ID to something other than ARM, which influences the definitions generated by the Platform/Windows-MSVC module (_PLATFORM_DEFINES_C, etc.).

(0033881) Brad King (manager) 2013-09-24 11:33 edited on: 2013-09-24 11:47	Untested patch: 0001-MSVC-Fix-WinCE-arch-family-preprocessor-symbol-for-A.patch

(0033882) Brad King (manager) 2013-09-24 11:54	Better patch, still untested: 0001-MSVC-Fix-WinCE-arch-family-preprocessor-symbol-14436.patch

(0033883) Brad King (manager) 2013-09-24 17:24	The regression in this issue is the sole blocker of CMake 2.8.12-rc4. Please try out 0001-MSVC-Fix-WinCE-arch-family-preprocessor-symbol-14436.patch ASAP.

(0033887) mar-na (reporter) 2013-09-25 07:40	Thank you very much for the quick reply. I tested the patch and it works for me.

(0033890) Brad King (manager) 2013-09-25 08:28	Patrick applied the patch here: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0b15ffc7 [^] Thanks for testing!

(0035267) Robert Maynard (manager) 2014-03-05 09:58	Closing resolved issues that have not been updated in more than 4 months

Issue History
Date Modified	Username	Field	Change
2013-09-24 10:21	mar-na	New Issue
2013-09-24 10:24	mar-na	Note Added: 0033876
2013-09-24 10:27	mar-na	Note Added: 0033877
2013-09-24 10:40	Brad King	Assigned To	=> Patrick R. Gansterer
2013-09-24 10:40	Brad King	Status	new => assigned
2013-09-24 10:43	Brad King	Relationship added	related to 0014420
2013-09-24 10:53	Brad King	Target Version	=> CMake 2.8.12
2013-09-24 11:17	Brad King	Note Added: 0033880
2013-09-24 11:19	Brad King	Relationship added	related to 0014083
2013-09-24 11:33	Brad King	Note Added: 0033881
2013-09-24 11:45	Brad King	File Added: 0001-MSVC-Fix-WinCE-arch-family-preprocessor-symbol-for-A.patch
2013-09-24 11:47	Brad King	Note Edited: 0033881
2013-09-24 11:53	Brad King	File Added: 0001-MSVC-Fix-WinCE-arch-family-preprocessor-symbol-14436.patch
2013-09-24 11:54	Brad King	Note Added: 0033882
2013-09-24 17:24	Brad King	Note Added: 0033883
2013-09-25 07:40	mar-na	Note Added: 0033887
2013-09-25 08:14	Brad King	Relationship added	related to 0014440
2013-09-25 08:28	Brad King	Note Added: 0033890
2013-09-25 08:28	Brad King	Status	assigned => resolved
2013-09-25 08:28	Brad King	Resolution	open => fixed
2013-09-25 08:28	Brad King	Fixed in Version	=> CMake 2.8.12
2014-03-05 09:58	Robert Maynard	Note Added: 0035267
2014-03-05 09:58	Robert Maynard	Status	resolved => closed