(0031961)
Jeremy Cook (reporter)
2013-01-03 09:17

This is the same as 0013789 and appears to be resolved. Sorry...

(0032974)
Richard Ulrich (reporter)
2013-05-06 07:39

I'm trying to add a merge module.
Thus I copied WIX.template.in from the cmake Modules directory to the Modules directory local in my project.
But I couldn't figure out how to add the Merge tag into the template.
It would have to be within the main Directory tag. But the Directory tag is entirely generated by cmCPackWIXGenerator.cxx.
So, I guess the way to do it would be to extend cmCPackWIXGenerator.cxx with allowing a list of merge modules?

(0032975)
Richard Ulrich (reporter)
2013-05-06 08:05

Also, how does localization work with this type of installer?

(0032976)
Eric NOULARD (developer)
2013-05-06 08:21
edited on: 2013-05-06 08:21

Hi Richard,

It looks like this bug is a sibling of 0013789 and that your problem
with "Merge Module" is not handled at all by the current WIX generator.

And yes the "Directory" part of the generated wxs file is done
in the CXX part.
Source/CPack/WiX/cmCPackWIXGenerator.cxx:267 and after

That said I don't know anything about how WiX works and what is the "Merge Module" objective.
(beside what is written here:
http://wix.sourceforge.net/manual-wix2/authoring_merge_modules.htm [^])

So I suggest you start a discussion on that topic on the CMake developer ML
(http://www.cmake.org/mailman/listinfo/cmake-developers [^]) explaining the feature you need and then you may get valuable answer from initial CPack WiX generator developers.

(0032978)
Richard Ulrich (reporter)
2013-05-06 09:10

Hi Eric,

thanks for the quick reply.
I figured a way to get my merge module included without having to touch the cpp source.
There might be nicer ways, but inserting the following inside the Product tag works for me:

        <DirectoryRef Id="TARGETDIR">
            <Merge Id="VC10MFC" Language="0" DiskId="1" SourceFile="$(env.ProgramFiles(x86))\Common Files\Merge Modules\Microsoft_VC100_MFC_x86.msm" />
            <Merge Id="VC10CRT" Language="0" DiskId="1" SourceFile="$(env.ProgramFiles(x86))\Common Files\Merge Modules\Microsoft_VC100_CRT_x86.msm" />
        </DirectoryRef>
        <Feature Id="runtimes" Title="3rd party runtime libraries" Level="1" Description='3rd party libraries necessary for operation' Display='expand'>
            <MergeRef Id='VC10MFC' />
            <MergeRef Id='VC10CRT' />
       </Feature>

(0035280)
Robert Maynard (manager)
2014-03-05 09:58

Closing resolved issues that have not been updated in more than 4 months

Issue History
Date Modified	Username	Field	Change
2013-01-03 09:12	Jeremy Cook	New Issue
2013-01-03 09:17	Jeremy Cook	Note Added: 0031961
2013-01-03 10:46	Eric NOULARD	Relationship added	duplicate of 0013789
2013-05-06 07:39	Richard Ulrich	Note Added: 0032974
2013-05-06 08:05	Richard Ulrich	Note Added: 0032975
2013-05-06 08:21	Eric NOULARD	Note Added: 0032976
2013-05-06 08:21	Eric NOULARD	Note Edited: 0032976
2013-05-06 09:10	Richard Ulrich	Note Added: 0032978
2013-10-12 17:12	Nils Gladitz	Status	new => assigned
2013-10-12 17:12	Nils Gladitz	Assigned To	=> Nils Gladitz
2013-10-15 03:12	Nils Gladitz	Status	assigned => resolved
2013-10-15 03:12	Nils Gladitz	Resolution	open => duplicate
2014-03-05 09:58	Robert Maynard	Note Added: 0035280
2014-03-05 09:58	Robert Maynard	Status	resolved => closed

Notes
(0031961) Jeremy Cook (reporter) 2013-01-03 09:17	This is the same as 0013789 and appears to be resolved. Sorry...

(0032974) Richard Ulrich (reporter) 2013-05-06 07:39	I'm trying to add a merge module. Thus I copied WIX.template.in from the cmake Modules directory to the Modules directory local in my project. But I couldn't figure out how to add the Merge tag into the template. It would have to be within the main Directory tag. But the Directory tag is entirely generated by cmCPackWIXGenerator.cxx. So, I guess the way to do it would be to extend cmCPackWIXGenerator.cxx with allowing a list of merge modules?

(0032975) Richard Ulrich (reporter) 2013-05-06 08:05	Also, how does localization work with this type of installer?

(0032976) Eric NOULARD (developer) 2013-05-06 08:21 edited on: 2013-05-06 08:21	Hi Richard, It looks like this bug is a sibling of 0013789 and that your problem with "Merge Module" is not handled at all by the current WIX generator. And yes the "Directory" part of the generated wxs file is done in the CXX part. Source/CPack/WiX/cmCPackWIXGenerator.cxx:267 and after That said I don't know anything about how WiX works and what is the "Merge Module" objective. (beside what is written here: http://wix.sourceforge.net/manual-wix2/authoring_merge_modules.htm [^]) So I suggest you start a discussion on that topic on the CMake developer ML (http://www.cmake.org/mailman/listinfo/cmake-developers [^]) explaining the feature you need and then you may get valuable answer from initial CPack WiX generator developers.

(0032978) Richard Ulrich (reporter) 2013-05-06 09:10	Hi Eric, thanks for the quick reply. I figured a way to get my merge module included without having to touch the cpp source. There might be nicer ways, but inserting the following inside the Product tag works for me: <DirectoryRef Id="TARGETDIR"> <Merge Id="VC10MFC" Language="0" DiskId="1" SourceFile="$(env.ProgramFiles(x86))\Common Files\Merge Modules\Microsoft_VC100_MFC_x86.msm" /> <Merge Id="VC10CRT" Language="0" DiskId="1" SourceFile="$(env.ProgramFiles(x86))\Common Files\Merge Modules\Microsoft_VC100_CRT_x86.msm" /> </DirectoryRef> <Feature Id="runtimes" Title="3rd party runtime libraries" Level="1" Description='3rd party libraries necessary for operation' Display='expand'> <MergeRef Id='VC10MFC' /> <MergeRef Id='VC10CRT' /> </Feature>

(0035280) Robert Maynard (manager) 2014-03-05 09:58	Closing resolved issues that have not been updated in more than 4 months