View Issue Details [ Jump to Notes ]

Project

Tags

No tags attached.

findLAPACK-Master.patch [^] (761 bytes) 2011-12-13 13:38 [Show Content] [Hide Content]

From cc6c710d5827eebe83b89d8f154d1b7f96857285 Mon Sep 17 00:00:00 2001
From: Tim Gallagher <tim.gallagher@gatech.edu>
Date: Tue, 13 Dec 2011 13:33:31 -0500
Subject: [PATCH] Fixed a bug preventing linking of threads in FindLAPACK

---
 Modules/FindLAPACK.cmake |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Modules/FindLAPACK.cmake b/Modules/FindLAPACK.cmake
index f88eed0..42cdbaa 100644
--- a/Modules/FindLAPACK.cmake
+++ b/Modules/FindLAPACK.cmake
@@ -123,7 +123,7 @@ if(_libraries_work)
 endif(_libraries_work)
 
  if(_libraries_work)
-   set(${LIBRARIES} ${${LIBRARIES}} ${_blas})
+   set(${LIBRARIES} ${${LIBRARIES}} ${_blas} ${_threads})
  else(_libraries_work)
     set(${LIBRARIES} FALSE)
  endif(_libraries_work)
-- 
1.7.7

findLAPACK-Release.patch [^] (761 bytes) 2011-12-13 13:38 [Show Content] [Hide Content]

From 54946b20a876ab18cea0a54039b07f1642016385 Mon Sep 17 00:00:00 2001
From: Tim Gallagher <tim.gallagher@gatech.edu>
Date: Tue, 13 Dec 2011 13:34:54 -0500
Subject: [PATCH] Fixed a bug preventing linking of threads in FindLAPACK

---
 Modules/FindLAPACK.cmake |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Modules/FindLAPACK.cmake b/Modules/FindLAPACK.cmake
index f88eed0..42cdbaa 100644
--- a/Modules/FindLAPACK.cmake
+++ b/Modules/FindLAPACK.cmake
@@ -123,7 +123,7 @@ if(_libraries_work)
 endif(_libraries_work)
 
  if(_libraries_work)
-   set(${LIBRARIES} ${${LIBRARIES}} ${_blas})
+   set(${LIBRARIES} ${${LIBRARIES}} ${_blas} ${_threads})
  else(_libraries_work)
     set(${LIBRARIES} FALSE)
  endif(_libraries_work)
-- 
1.7.7

Relationships

Notes
(0027957) tgallagher (developer) 2011-12-13 13:38	When testing that the libraries works, it links against the threads library, but then when returning the libraries needed, the threads library is not included in the list. I've uploaded patches to fix this on both release (2.8.6) and master.

(0027959) David Cole (manager) 2011-12-13 16:20	FYI: when posting patches, you only need to post patches against 'master' - our workflow bases all new work on master and merges work in to other branches after that as needed.

(0027960) tgallagher (developer) 2011-12-13 16:23	Not a problem, I was going off of: http://www.cmake.org/Wiki/CMake/Git/Develop [^] Which under the "Create a Topic" section says to go off of origin/release if it is a bug in the latest release.

(0027961) David Cole (manager) 2011-12-13 16:33	No problem -- that comment about building off of "origin/release" would be if we were going to build a new patch release (in this case, something like a 2.8.6.1 just to include this bug fix)... If you submit patches on origin/master, that's good enough for most cases. If it's hard to cherry-pick or otherwise get onto release and we need to, we'll ask for you help then. Thanks!

(0027962) David Cole (manager) 2011-12-13 19:17	Fix pushed to 'next' today: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b3c42cb0123c7d21b6a23b1b7517cbb27d55df76 [^]

(0029441) David Cole (manager) 2012-05-09 15:26	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2011-12-13 13:37	tgallagher	New Issue
2011-12-13 13:38	tgallagher	Note Added: 0027957
2011-12-13 13:38	tgallagher	File Added: findLAPACK-Master.patch
2011-12-13 13:38	tgallagher	File Added: findLAPACK-Release.patch
2011-12-13 16:19	David Cole	Assigned To	=> David Cole
2011-12-13 16:19	David Cole	Status	new => assigned
2011-12-13 16:20	David Cole	Note Added: 0027959
2011-12-13 16:23	tgallagher	Note Added: 0027960
2011-12-13 16:33	David Cole	Note Added: 0027961
2011-12-13 19:16	David Cole	Target Version	=> CMake 2.8.7
2011-12-13 19:17	David Cole	Note Added: 0027962
2011-12-16 10:12	David Cole	Status	assigned => resolved
2011-12-16 10:12	David Cole	Fixed in Version	=> CMake 2.8.7
2011-12-16 10:12	David Cole	Resolution	open => fixed
2012-05-09 15:26	David Cole	Note Added: 0029441
2012-05-09 15:26	David Cole	Status	resolved => closed