View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0012262CMakeCMakepublic2011-06-09 15:532012-01-03 14:59
ReporterAmine Khaldi 
Assigned ToAlex Neundorf 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 2.8.7Fixed in VersionCMake 2.8.7 
Summary0012262: Dependencies aren't tracked for preprocessed asm
DescriptionWe (ReactOS) use preprocessed asm files, that have includes, as source files in our modules.

CMake currently doesn't track these includes for those asm source files.

The only solution we see is to maintain a list of OBJECT_DEPENDS applied to every single preprocessed asm source file we have, which is far from practical.
Steps To ReproduceCreate a project with a preprocessed asm file that includes a dummy header, then after compiling the first time, alter the header and recompile, and you'll see that the project isn't properly recompiled.
TagsNo tags attached.
Attached Fileszip file icon testcase.zip [^] (873 bytes) 2011-12-18 10:56

 Relationships

  Notes
(0027529)
Alex Neundorf (developer)
2011-10-05 15:57

Fixed and pushed to the cmake stage in the "DependencyScanningForASM" branch, also already merged into next.
Can you please verify that it works for you too ?
It does enable dependency scanning for the test project I have here.

Alex
(0027997)
Amine Khaldi (reporter)
2011-12-17 03:22

Hi,

Alex, I tested it per your request at that time, but it wasn't possible to add any replies here (the status didn't permit ?).

The header includes (including .h files) are correctly tracked now, but we also use the .inc extension for asm includes (for example #include <syscalls.inc>) but these are not being tracked at all.

Is it possible to track all the files included through #include regardless of their extension ?

Amine
(0027999)
Alex Neundorf (developer)
2011-12-18 09:12

It works here for me, and I also don't see a place in the code where this would be extension-dependent.

Can you create a small testcase ?

Alex
(0028002)
Amine Khaldi (reporter)
2011-12-18 10:57
edited on: 2011-12-18 10:59

In the attached testcase, target 'foo' uses #include "" and the dependencies are well tracked, but target 'bar' uses #include <> and the dependencies aren't tracked at all.

I reported previously that the .inc file wasn't tracked, but it turns out it's not about extensions, it's about #include "something" vs #include <something>, because that file was included using <>.

Amine.

(0028005)
Alex Neundorf (developer)
2011-12-18 13:09

Ok, fixed.
It is now in the UseEnabledLanguagesForDirectoryInformationFileIncludePath branch on cmake stage.
It is a bit intrusive, hopefully it will still be accepted for 2.8.7.
(0028008)
Amine Khaldi (reporter)
2011-12-19 09:42

The fix is confirmed. Thank you for working on it.
(0028149)
Alex Neundorf (developer)
2012-01-03 14:59

Works now, as confirmed by the reporter.

 Issue History
Date Modified Username Field Change
2011-06-09 15:53 Amine Khaldi New Issue
2011-06-09 16:55 Alex Neundorf Assigned To => Alex Neundorf
2011-06-09 16:55 Alex Neundorf Status new => assigned
2011-10-05 15:57 Alex Neundorf Note Added: 0027529
2011-10-05 15:57 Alex Neundorf Status assigned => closed
2011-10-05 15:57 Alex Neundorf Resolution open => fixed
2011-12-16 17:15 David Cole Fixed in Version => CMake 2.8.7
2011-12-16 17:15 David Cole Target Version => CMake 2.8.7
2011-12-17 03:22 Amine Khaldi Note Added: 0027997
2011-12-17 03:22 Amine Khaldi Status closed => feedback
2011-12-17 03:22 Amine Khaldi Resolution fixed => reopened
2011-12-18 09:12 Alex Neundorf Note Added: 0027999
2011-12-18 10:56 Amine Khaldi File Added: testcase.zip
2011-12-18 10:57 Amine Khaldi Note Added: 0028002
2011-12-18 10:57 Amine Khaldi Status feedback => assigned
2011-12-18 10:59 Amine Khaldi Note Edited: 0028002
2011-12-18 13:09 Alex Neundorf Note Added: 0028005
2011-12-19 09:42 Amine Khaldi Note Added: 0028008
2012-01-03 14:59 Alex Neundorf Note Added: 0028149
2012-01-03 14:59 Alex Neundorf Status assigned => closed
2012-01-03 14:59 Alex Neundorf Resolution reopened => fixed


Copyright © 2000 - 2018 MantisBT Team