View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0011761CMakeCMakepublic2011-01-25 22:392011-06-17 18:25
ReporterDaniel Nelson 
Assigned ToDavid Cole 
PrioritynormalSeveritytweakReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 2.8.3 
Target VersionCMake 2.8.5Fixed in VersionCMake 2.8.5 
Summary0011761: FILE(DOWNLOAD ) md5 checking is too noisy
DescriptionWhen FILE(DOWNLOAD ) finds a file where the EXPECTED_MD5 matches an already existing file and skips downloading, it displays the status message:
-- FILE(DOWNLOAD) returning early: file already exists with expected MD5 sum

This can be a little annoying if you download several files in a project, and its displayed every time the CMakeLists are reread. I think this message should be removed.

Other cmake commands are silent when they complete successfully, and a matching md5 is success. Also the user can still retrieve the message from the STATUS variable.
Steps To ReproduceUse FILE(DOWNLOAD) with the EXPECTED_MD5 argument. After running cmake, run make rebuild_cache.
TagsNo tags attached.
Attached Filespatch file icon file-download-quiet.patch [^] (509 bytes) 2011-01-25 22:39 [Show Content]
patch file icon file-download-quiet-2.patch [^] (911 bytes) 2011-01-26 14:16 [Show Content]

 Relationships

  Notes
(0025081)
David Cole (manager)
2011-01-26 08:59

Good suggestion. The reason the "returning early" string is printed was just for positive feedback during development. Now that the feature is well used without other complaints, taking this string out is reasonable.
(0025082)
David Cole (manager)
2011-01-26 09:06

Note: the test of this feature depends on this string in the output of the test to pass. So when we remove the DisplayStatus call here, we'll have to update the test to use the FILE(DOWNLOAD ... STATUS ...) argument and print it out from the test.

See CMake/Tests/CMakeTests/FileDownloadTest.cmake.in and its associated PASS_REGULAR_EXPRESSION in the CMakeLists file.
(0025356)
David Cole (manager)
2011-02-09 13:33

Fix pushed to 'next'
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=667cf5b96368205544fb82ccce81358957987720 [^]
(0026721)
David Cole (manager)
2011-06-06 18:25

Closing resolved issues that have not been updated in more than 3 months.

 Issue History
Date Modified Username Field Change
2011-01-25 22:39 Daniel Nelson New Issue
2011-01-25 22:39 Daniel Nelson File Added: file-download-quiet.patch
2011-01-26 08:57 David Cole Assigned To => David Cole
2011-01-26 08:57 David Cole Status new => assigned
2011-01-26 08:59 David Cole Note Added: 0025081
2011-01-26 09:06 David Cole Note Added: 0025082
2011-01-26 14:16 Daniel Nelson File Added: file-download-quiet-2.patch
2011-02-09 13:33 David Cole Note Added: 0025356
2011-02-09 13:33 David Cole Status assigned => resolved
2011-02-09 13:33 David Cole Resolution open => fixed
2011-02-16 11:44 David Cole Target Version => CMake 2.8.5
2011-06-06 18:25 David Cole Status resolved => closed
2011-06-06 18:25 David Cole Note Added: 0026721
2011-06-17 18:25 David Cole Fixed in Version => CMake 2.8.5


Copyright © 2000 - 2018 MantisBT Team