View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0011283

CMake

public

2010-09-30 22:23

2010-10-06 13:39

Reporter

amir

Assigned To

Brad King

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

CMake-2-8

Target Version

CMake 2.8.3

Fixed in Version

CMake 2.8.3

Summary

0011283: Visual Studio will treat text after linefeed inside custom build command comment as executable/batch file

Description

Visual Studio 2010, but also most likely all versions using XML project files will not process linefeeds correctly. Instead of printing them VS will try and execute them as executables. If its an existing file that is not an executable Windows will ask what program to use to open the file.

Attached is a patch file fixing this for VS2010 only.

I do not have any other VS version installed, so I can not test them.

Here is what I found via Google:
http://www.mail-archive.com/cmake@cmake.org/msg01630.html [^]

Additional Information

add_custom_command(
    OUTPUT ${CMAKE_CURRENT_SOURCE_DIR}/dialog_freeroute_exchange_help_html.h
    COMMAND ${CMAKE_COMMAND}
        -DinputFile=${CMAKE_CURRENT_SOURCE_DIR}/dialog_freeroute_exchange_help.html
        -DoutputFile=${CMAKE_CURRENT_SOURCE_DIR}/dialog_freeroute_exchange_help_html.h
        -P ${CMAKE_MODULE_PATH}/Html2C.cmake
    DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/dialog_freeroute_exchange_help.html
    COMMENT "creating ${CMAKE_CURRENT_SOURCE_DIR}/dialog_freeroute_exchange_help_html.h
        from ${CMAKE_CURRENT_SOURCE_DIR}/dialog_freeroute_exchange_help.html"
    )

Will result in a project file containing:

<Message Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">creating
    C:/temp/kicad/ash/pcbnew/dialog_freeroute_exchange_help_html.h
    from C:/temp/kicad/ash/pcbnew/dialog_freeroute_exchange_help.html</Message>

Visual Studio will only print "creating" to the output and then proceed to hand dialog_freeroute_exchange_help_html.h to the OS for opening.

Tags

comment, linefeed, multiline, visual studio 2010, vs2010

Attached Files

cmake-patch [^] (984 bytes) 2010-09-30 22:23 [Show Content] [Hide Content]

 Source/cmVisualStudio10TargetGenerator.cxx |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/Source/cmVisualStudio10TargetGenerator.cxx b/Source/cmVisualStudio10TargetGenerator.cxx
index 59e20d5..180a834 100644
--- a/Source/cmVisualStudio10TargetGenerator.cxx
+++ b/Source/cmVisualStudio10TargetGenerator.cxx
@@ -318,6 +318,12 @@ cmVisualStudio10TargetGenerator::WriteCustomRule(cmSourceFile* source,
     }
   cmLocalVisualStudio7Generator* lg = this->LocalGenerator;
   std::string comment = lg->ConstructComment(command);
+
+  // Inside the comment section Visual Studio will treat everything after a line break as an executable
+  // or batch file and tries to execute it
+  cmSystemTools::ReplaceString(comment, "\n", " ");
+  cmSystemTools::ReplaceString(comment, "\r", "");
+
   std::vector<std::string> *configs =
     static_cast<cmGlobalVisualStudio7Generator *>
     (this->GlobalGenerator)->GetConfigurations();
--
1.7.1

Relationships

Notes
(0022402) Brad King (manager) 2010-10-04 09:27	Fixed: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2596e16c [^]

Issue History
Date Modified	Username	Field	Change
2010-09-30 22:23	amir	New Issue
2010-09-30 22:23	amir	File Added: cmake-patch
2010-09-30 22:26	amir	Tag Attached: comment
2010-09-30 22:26	amir	Tag Attached: linefeed
2010-09-30 22:26	amir	Tag Attached: multiline
2010-09-30 22:26	amir	Tag Attached: visual studio 2010
2010-09-30 22:26	amir	Tag Attached: vs2010
2010-10-01 12:27	Bill Hoffman	Status	new => assigned
2010-10-01 12:27	Bill Hoffman	Assigned To	=> Brad King
2010-10-04 09:27	Brad King	Note Added: 0022402
2010-10-04 09:28	Brad King	Status	assigned => closed
2010-10-04 09:28	Brad King	Resolution	open => fixed
2010-10-06 13:39	David Cole	Fixed in Version	=> CMake 2.8.3
2010-10-06 13:39	David Cole	Target Version	=> CMake 2.8.3
2010-10-06 13:39	David Cole	Description Updated