View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0011273CMakeCMakepublic2010-09-29 04:002010-10-26 16:34
ReporterRolf Eike Beer 
Assigned ToBrad King 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 2.8.3Fixed in VersionCMake 2.8.3 
Summary0011273: FindSubversion breaks with German SilkSVN
DescriptionOn a Win32 system with a German version of SilkSVN I can't run CMake again on the working copy as the cache is displayed as corrupted. The cause is that the regular expression to find the version number will not match and put everything from the "svn --version" output into the cache, which contains umlauts and other funny characters.

The attached patch fixes the regexp to not only match " version " but also " Version " as it's in the German output. I have no idea what will happen on a French or Japanese system. This should be easy to test as it happens also on a German Linux system.
Additional InformationI could reproduce this on a Linux system by setting the LANG environment variable to de_DE.UTF-8. I'm not sure if there's an equivalent environment variable for Windows. If so, you could set it to en_US.UTF-8, as a workaround.
TagsNo tags attached.
Attached Filespatch file icon 0001-fix-FindSubversion-with-German-localized-client-1127.patch [^] (1,042 bytes) 2010-10-06 18:25 [Show Content]
patch file icon 0001-make-Subversion-version-detection-work-with-all-loca.patch [^] (1,522 bytes) 2010-10-07 10:37 [Show Content]

 Relationships

  Notes
(0022433)
Brad King (manager)
2010-10-07 10:12

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=42126aaf [^]
(0022435)
Rolf Eike Beer (developer)
2010-10-07 10:37

Now that the first fix is merged I find the proper solution which was only a few lines down in the same file.
(0022437)
Brad King (manager)
2010-10-07 11:13

[smacks forehead]

Yes, of course that is the correct fix. Thanks.

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d2f8c5f8 [^]

 Issue History
Date Modified Username Field Change
2010-09-29 04:00 Rolf Eike Beer New Issue
2010-10-06 18:25 Rolf Eike Beer File Added: 0001-fix-FindSubversion-with-German-localized-client-1127.patch
2010-10-07 06:22 Marcel Loose Status new => acknowledged
2010-10-07 06:22 Marcel Loose Additional Information Updated
2010-10-07 10:11 Brad King Status acknowledged => assigned
2010-10-07 10:11 Brad King Assigned To => Brad King
2010-10-07 10:12 Brad King Note Added: 0022433
2010-10-07 10:12 Brad King Status assigned => closed
2010-10-07 10:12 Brad King Resolution open => fixed
2010-10-07 10:37 Rolf Eike Beer Note Added: 0022435
2010-10-07 10:37 Rolf Eike Beer Status closed => feedback
2010-10-07 10:37 Rolf Eike Beer Resolution fixed => reopened
2010-10-07 10:37 Rolf Eike Beer File Added: 0001-make-Subversion-version-detection-work-with-all-loca.patch
2010-10-07 11:13 Brad King Note Added: 0022437
2010-10-07 11:13 Brad King Status feedback => closed
2010-10-07 11:13 Brad King Resolution reopened => fixed
2010-10-26 16:34 David Cole Fixed in Version => CMake 2.8.3
2010-10-26 16:34 David Cole Target Version => CMake 2.8.3


Copyright © 2000 - 2018 MantisBT Team