MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003664CMakeCMakepublic2006-08-26 17:522006-10-04 11:34
ReporterErwin Coumans 
Assigned ToBill Hoffman 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0003664: problems with extra quotes in msvc preprocessor defines
DescriptionADD_DEFINITIONS(-DSN_TARGET_PS3)
Then cmake autogenerates:

PreprocessorDefinitions=","SN_TARGET_PS3","
It should be:
PreprocessorDefinitions="SN_TARGET_PS3"

Is there a template that I can edit to solve this, or does it require
C/C++ modifications?

Some programs are incompatible with the additional quotes. In particular, SN Systems compiler (in MSVC) doesn't recognize the proprocessor defines inside additional quotes.

This would be a showstopper (hence Critical) for our project.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange

Notes
(0004755)
Erwin Coumans   
2006-08-26 17:53   
This might be related to this bug, but just to make sure the quotes-problem gets attention:

http://www.cmake.org/Bug/bug.php?op=show&bugid=3354 [^]
(0005021)
Brad King   
2006-09-23 16:59   
To setup the previous link inside the bug tracker: This overlaps with bug 0003354.

It also is related to bug 0003786.
(0005133)
Bill Hoffman   
2006-10-04 11:34   
Checking for path: /cvsroot/CMake/CMake/Source
Unrestricted user: hoffman
/cvsroot/CMake/CMake/Source/cmLocalVisualStudio7Generator.cxx,v <-- cmLocalVisualStudio7Generator.cxx
new revision: 1.150; previous revision: 1.149

It was being safe, if there are chars other than:
-_abcdefghigklmnopqrstuvwxyz1234567890ABCDEFGHIGKLMNOPQRSTUVWXYZ"
it will put the quotes in so you can have spaces and such.