View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0015066

CMake

CTest

public

2014-08-06 17:58

2015-01-05 08:39

Reporter

Ken Moreland

Assigned To

Brad King

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

Windows

OS Version

Product Version

CMake 3.0

Target Version

CMake 3.1

Fixed in Version

CMake 3.1

Summary

0015066: MSVC level 3 warning in test code

Description

I like to compile my code in MSVC with level 3 warnings on (/W3 compiler flag), but this causes problems with code generated with the create_test_sourcelist() command. (That is, the code in TestDriver.cxx.in.) This code uses the functions strcpy and scanf, and the MSVC compiler gives an error for using each of them because each are notorious for leading to security problems.

Although the use of each of these is correct, TestDriver.cxx.in should be changed to suppress the warning in some way. Either the code should use "safe" alternatives for these functions or the warning should be disabled with something like "#pragma warning(disable : 4996)".

Tags

No tags attached.

Attached Files

0001-create_test_sourcelist-Suppress-MSVC-warnings-in-tes.patch [^] (816 bytes) 2014-08-07 09:16 [Show Content] [Hide Content]

From 63fc8dcdb82e91b7218aab959d75f924f6a01bc1 Mon Sep 17 00:00:00 2001
Message-Id: <63fc8dcdb82e91b7218aab959d75f924f6a01bc1.1407417496.git.brad.king@kitware.com>
From: Brad King <brad.king@kitware.com>
Date: Thu, 7 Aug 2014 09:15:17 -0400
Subject: [PATCH] create_test_sourcelist: Suppress MSVC warnings in test driver
 (#15066)

Suggested-by: Ken Moreland <kmorel@sandia.gov>
---
 Templates/TestDriver.cxx.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Templates/TestDriver.cxx.in b/Templates/TestDriver.cxx.in
index 0e0a872..ffa6999 100644
--- a/Templates/TestDriver.cxx.in
+++ b/Templates/TestDriver.cxx.in
@@ -3,6 +3,10 @@
 #include <string.h>
 #include <stdlib.h>
 
+#if defined(_MSC_VER)
+# pragma warning(disable:4996) /* deprecation */
+#endif
+
 @CMAKE_TESTDRIVER_EXTRA_INCLUDES@
 
 
-- 
2.0.0

Relationships

Notes
(0036573) Brad King (manager) 2014-08-07 09:17	Please try "0001-create_test_sourcelist-Suppress-MSVC-warnings-in-tes.patch".

(0036607) Ken Moreland (reporter) 2014-08-12 15:45	The patch is working for me.

(0036608) Brad King (manager) 2014-08-12 15:51	Thanks for testing. Applied: create_test_sourcelist: Suppress MSVC warnings in test driver http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=63fc8dcd [^]

(0037613) Robert Maynard (manager) 2015-01-05 08:39	Closing resolved issues that have not been updated in more than 4 months

Issue History
Date Modified	Username	Field	Change
2014-08-06 17:58	Ken Moreland	New Issue
2014-08-07 09:16	Brad King	File Added: 0001-create_test_sourcelist-Suppress-MSVC-warnings-in-tes.patch
2014-08-07 09:17	Brad King	Note Added: 0036573
2014-08-07 09:17	Brad King	Assigned To	=> Brad King
2014-08-07 09:17	Brad King	Status	new => assigned
2014-08-07 09:17	Brad King	Target Version	=> CMake 3.1
2014-08-12 15:45	Ken Moreland	Note Added: 0036607
2014-08-12 15:51	Brad King	Note Added: 0036608
2014-08-18 11:12	Brad King	Status	assigned => resolved
2014-08-18 11:12	Brad King	Resolution	open => fixed
2014-08-18 11:12	Brad King	Fixed in Version	=> CMake 3.1
2015-01-05 08:39	Robert Maynard	Note Added: 0037613
2015-01-05 08:39	Robert Maynard	Status	resolved => closed