View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014576CMakeCMakepublic2013-11-17 18:262016-06-10 14:21
ReporterPaul Smith 
Assigned ToEric NOULARD 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 2.8.12 
Target VersionFixed in Version 
Summary0014576: cmake-mode.el is using an illegal keymap
DescriptionThe GNU Emacs manual describes the keys in the map C-c <letter> as reserved for use by the user, where modes should not infringe. See http://www.gnu.org/software/emacs/manual/html_node/elisp/Key-Binding-Conventions.html [^] second bullet:

> Don't define C-c _letter_ as a key in Lisp programs. Sequences
> consisting of C-c and a letter (either upper or lower case) are
> reserved for users; they are the only sequences reserved for users, so
> do not block them.
> Changing all the Emacs major modes to respect this convention was a
> lot of work; abandoning this convention would make that work go to
> waste, and inconvenience users. Please comply with it.

However, in the cmake-mode.el that comes with cmake, it defines a map that uses those reserved keys:

  (defvar cmake-mode-map
    (let ((map (make-sparse-keymap)))
      (define-key map "\C-ch" 'cmake-help-command)
      (define-key map "\C-cl" 'cmake-help-list-commands)
      (define-key map "\C-cu" 'unscreamify-cmake-buffer)
      map)
    "Keymap used in cmake-mode buffers.")

This map needs to be changed to use some other set of keys, that don't match the C-c <letter> reserved list.
TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0034457)
Brad King (manager)
2013-11-18 08:33

 Eric, it looks like you committed this patch here:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=301e67e3 [^]

IMO we should just drop this.
(0034460)
Eric NOULARD (developer)
2013-11-18 09:02

 You are right and I'm ok with dropping this commit.

Something is puzzling me because I cannot track down
any e-mail exchange with Tom about that.
I usually don't do that (commit external contrib')
without any direct discussion. May be the discussion took place
in the mantis tracker.
I'll dig further later on I'm lacking time for that right now.

Anyhow,
If you are Ok I let you drop that commit yourself
in order not to interfere with the current dashboard issue.
(0034461)
Brad King (manager)
2013-11-18 09:38

 Okay, I reverted the commit mentioned in 0014576:0034457:

 cmake-mode.el: drop reserved keybindings
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0f212618 [^]
(0041079)
Paul Smith (reporter)
2016-05-20 14:40

 Is this still open for a reason? It seems to have been resolved back in 2013...?
(0041080)
Brad King (manager)
2016-05-20 14:42

 Re 0014576:0041079: Thanks.
(0041167)
Kitware Robot (administrator)
2016-06-10 14:21

 This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

 Issue History
Date Modified Username Field Change
2013-11-17 18:26 Paul Smith New Issue
2013-11-18 08:33 Brad King Note Added: 0034457
2013-11-18 09:02 Eric NOULARD Note Added: 0034460
2013-11-18 09:38 Brad King Note Added: 0034461
2013-11-18 09:38 Brad King Assigned To => Eric NOULARD
2013-11-18 09:38 Brad King Status new => backlog
2016-05-20 14:40 Paul Smith Note Added: 0041079
2016-05-20 14:42 Brad King Status backlog => resolved
2016-05-20 14:42 Brad King Resolution open => fixed
2016-05-20 14:42 Brad King Note Added: 0041080
2016-06-10 14:21 Kitware Robot Note Added: 0041167
2016-06-10 14:21 Kitware Robot Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team