View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014239CMakeModulespublic2013-06-21 02:432013-11-04 09:33
Reportermh 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformPCOSWindowsOS Version7 SP1
Product VersionCMake 2.8.11.1 
Target VersionCMake 2.8.12Fixed in VersionCMake 2.8.12 
Summary0014239: CMakeDetermineVSServicePack does recognize neither Update 1 nor Update 2 for Visual Studio 2012
DescriptionCMakeDetermineVSServicePack.cmake, which we use to ensure that our projects are only built using a supported version of Visual Studio, does not recognize VS 2012 with Update 1 or 2 installed. The return value is an empty string.

This should be easy to fix: Add the new cl versions in Modules/CMakeDetermineVSServicePack.cmake around line 60. The x86_amd64 cl.exe on my system with Update 2 installed reports "17.0.60315.1". The new '_version' could be either 'vc110up2' or 'vc110sp2'.

One problem that could arise: I've read on http://connect.microsoft.com/VisualStudio/feedback/details/773126/visual-studio-2012-update-1-does-not-update-x64-native-compiler [^] and http://connect.microsoft.com/VisualStudio/feedback/details/773126/visual-studio-2012-update-1-does-not-update-x64-native-compiler [^] (comment from 'Michael'), that the native x64 compilers version number did not change, at least for Update 1. I can't check this myself for Update 2, as the Express Edition used for evaluation does not seem to contain the x64 compiler.
TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0033366)
Brad King (manager)
2013-06-21 08:57

 After some documentation cleanup:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1746a35d [^]

I added the VS 11 updates:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2aa62e0b [^]

Note that these days you can use CMAKE_<LANG>_COMPILER_VERSION instead.
(0034377)
Robert Maynard (manager)
2013-11-04 09:33

 Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2013-06-21 02:43 mh New Issue
2013-06-21 08:57 Brad King Note Added: 0033366
2013-06-21 08:57 Brad King Assigned To => Brad King
2013-06-21 08:57 Brad King Status new => resolved
2013-06-21 08:57 Brad King Resolution open => fixed
2013-06-21 08:57 Brad King Fixed in Version => CMake 2.8.12
2013-06-21 08:57 Brad King Target Version => CMake 2.8.12
2013-11-04 09:33 Robert Maynard Note Added: 0034377
2013-11-04 09:33 Robert Maynard Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team