View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0013959 | CMake | Modules | public | 2013-02-27 11:56 | 2016-06-10 14:31 | ||||
Reporter | Julian Ospald | ||||||||
Assigned To | Kitware Robot | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | moved | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0013959: FindFreetype.cmake does not have a fallback (like pkgconfig or freetype-config) | ||||||||
Description | Freetype offers two ways to _correctly_ get the header and library location. a) via pkgconfig file (freetype2.pc) b) via freetype-config script The lack of any of the above checks can and does lead to cmake configure failures, especially since freetype supports installing the headers into a custom location, because they contain ABI-specific information. I am not suggesting to change the current module logic, but to just add a _fallback_ in case the current methods fail. And they already do for some usecases. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | FindFreetype.cmake.patch [^] (1,150 bytes) 2013-02-28 11:55 [Show Content]
0001-Support-finding-freetype2-using-pkg-config.patch [^] (1,965 bytes) 2013-02-28 12:17 [Show Content] | ||||||||
Relationships | |||||||||||
|
Relationships |
Notes | |
(0032413) Daniel Scharrer (reporter) 2013-02-28 11:55 |
Hi, my project uses CMake and Freetype and with the current FindFreetype.cmake it will inevitably break when a distro moves the Freetype headers to an architecture-specific location. I hope this can be fixed in CMake before then. I have attached a patch that uses the CMake's PkgConfig module to set get hints for the find_path and find_library calls in FindFreetype.cmake, like it is already used in other Find modules. I have however not tested that this will correctly pick up arch-specific header locations. |
(0032414) Michał Górny (reporter) 2013-02-28 12:13 |
Thanks for the patch, Daniel. You missed the includedir in the first block. I will attach a fixed and reindented patch in a minute ;). |
(0032689) Julian Ospald (reporter) 2013-03-23 20:59 |
At least this remains proof that cmake devs don't care about fixing their broken module logic. |
(0034694) Brad King (manager) 2013-12-03 13:12 |
The FindFreetype.cmake module needs a new volunteer maintainer and a major overhaul: http://www.cmake.org/Wiki/CMake:Module_Maintainers [^] Moving this issue to the backlog until that happens. |
(0042239) Kitware Robot (administrator) 2016-06-10 14:28 |
Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2013-02-27 11:56 | Julian Ospald | New Issue | |
2013-02-28 11:55 | Daniel Scharrer | File Added: FindFreetype.cmake.patch | |
2013-02-28 11:55 | Daniel Scharrer | Note Added: 0032413 | |
2013-02-28 12:13 | Michał Górny | Note Added: 0032414 | |
2013-02-28 12:17 | Michał Górny | File Added: 0001-Support-finding-freetype2-using-pkg-config.patch | |
2013-03-23 20:59 | Julian Ospald | Note Added: 0032689 | |
2013-11-27 11:09 | Brad King | Relationship added | related to 0014601 |
2013-11-27 11:11 | Brad King | Assigned To | => Eric Wing |
2013-11-27 11:11 | Brad King | Status | new => assigned |
2013-12-03 13:12 | Brad King | Note Added: 0034694 | |
2013-12-03 13:12 | Brad King | Assigned To | Eric Wing => |
2013-12-03 13:12 | Brad King | Status | assigned => backlog |
2013-12-03 13:16 | Brad King | Relationship added | related to 0014626 |
2016-06-10 14:28 | Kitware Robot | Note Added: 0042239 | |
2016-06-10 14:28 | Kitware Robot | Status | backlog => resolved |
2016-06-10 14:28 | Kitware Robot | Resolution | open => moved |
2016-06-10 14:28 | Kitware Robot | Assigned To | => Kitware Robot |
2016-06-10 14:31 | Kitware Robot | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |