View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0013085

CMake

CPack

public

2012-03-31 13:24

2013-01-09 10:55

Reporter

David Golub

Assigned To

David Cole

Priority

normal

Severity

minor

Reproducibility

N/A

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

CMake 2.8.7

Target Version

CMake 2.8.9

Fixed in Version

CMake 2.8.9

Summary

0013085: Unable to run custom NSIS commands before installation

Description

CPack provides the ability to run custom NSIS commands at the end of the setup process by setting the variable CPACK_NSIS_EXTRA_INSTALL_COMMANDS. However, there is no way to specify custom commands to run at the beginning of the setup process before files are copied. I'd like to submit a patch to address this issue.

diff --git a/Modules/CPackNSIS.cmake b/Modules/CPackNSIS.cmake
--- a/Modules/CPackNSIS.cmake
+++ b/Modules/CPackNSIS.cmake
@@ -29,8 +29,13 @@
##end
#
##variable
+# CPACK_NSIS_EXTRA_PREINSTALL_COMMANDS - Extra NSIS commands that will
+# be added to the beginning of the install Section.
+##end
+#
+##variable
# CPACK_NSIS_EXTRA_INSTALL_COMMANDS - Extra NSIS commands that will
-# be added to the install Section.
+# be added to the end of the install Section.
##end
#
##variable
diff --git a/Modules/NSIS.template.in b/Modules/NSIS.template.in
--- a/Modules/NSIS.template.in
+++ b/Modules/NSIS.template.in
@@ -637,6 +637,7 @@
   ;Use the entire tree produced by the INSTALL target. Keep the
   ;list of directories here in sync with the RMDir commands below.
   SetOutPath "$INSTDIR"
+ @CPACK_NSIS_EXTRA_PREINSTALL_COMMANDS@
   @CPACK_NSIS_FULL_INSTALL@

   ;Store installation folder

Tags

No tags attached.

Attached Files

Relationships

Notes
(0029298) David Cole (manager) 2012-04-22 12:07	Fix merged to the CMake 'next' branch yesterday: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=aa8acea3982582cb8e20f69ec897aed6dd31a0a5 [^]

(0032015) Robert Maynard (manager) 2013-01-09 10:55	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2012-03-31 13:24	David Golub	New Issue
2012-04-21 11:21	David Cole	Assigned To	=> David Cole
2012-04-21 11:21	David Cole	Status	new => assigned
2012-04-21 11:22	David Cole	Description Updated
2012-04-22 12:06	David Cole	Target Version	=> CMake 2.8.9
2012-04-22 12:07	David Cole	Note Added: 0029298
2012-04-22 12:07	David Cole	Status	assigned => resolved
2012-04-22 12:07	David Cole	Resolution	open => fixed
2012-08-09 16:55	David Cole	Fixed in Version	=> CMake 2.8.9
2013-01-09 10:55	Robert Maynard	Note Added: 0032015
2013-01-09 10:55	Robert Maynard	Status	resolved => closed