View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0012965

CMake

Modules

public

2012-02-17 11:18

2016-06-10 14:31

Reporter

Thomas Dziedzic

Assigned To

Kitware Robot

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

moved

Platform

linux

archlinux

OS Version

rolling release

Product Version

CMake 2.8.7

Target Version

Fixed in Version

Summary

0012965: FindRuby.cmake uses an incorrect method to detect if vendor directory is available.

Description

I'm specifically talking about the following line:
http://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/FindRuby.cmake;h=c4adfd1ee985a4f147796da654fa0b97fe61ee2f;hb=HEAD#l98 [^]

It seems that opensuse is the only distro shipping a vendor-specific.rb file which is not a standard ruby convention. Archlinux, Debian, probably no other distro uses this except Opensuse.

I emailed the opensuse ruby maintainer and he indeed said vendor-specific.rb was only introduced from macports. You should be checking if the following variables exist in ruby:

RbConfig::CONFIG['vendordir']
RbConfig::CONFIG['vendorlibdir']
RbConfig::CONFIG['vendorarchdir']

Tags

No tags attached.

Attached Files

cmake-findruby.patch [^] (1,069 bytes) 2012-05-21 12:37 [Show Content] [Hide Content]

diff -up cmake-2.8.8/Modules/FindRuby.cmake.findruby cmake-2.8.8/Modules/FindRuby.cmake
--- cmake-2.8.8/Modules/FindRuby.cmake.findruby	2012-04-18 12:10:54.000000000 -0600
+++ cmake-2.8.8/Modules/FindRuby.cmake	2012-05-21 10:36:19.206076083 -0600
@@ -92,14 +92,8 @@ IF(RUBY_EXECUTABLE  AND NOT  RUBY_VERSIO
    _RUBY_CONFIG_VAR("sitearchdir" RUBY_SITEARCH_DIR)
    _RUBY_CONFIG_VAR("sitelibdir" RUBY_SITELIB_DIR)
 
-   # vendor_ruby available ?
-   EXECUTE_PROCESS(COMMAND ${RUBY_EXECUTABLE} -r vendor-specific -e "print 'true'"
-      OUTPUT_VARIABLE RUBY_HAS_VENDOR_RUBY  ERROR_QUIET)
-
-   IF(RUBY_HAS_VENDOR_RUBY)
-      _RUBY_CONFIG_VAR("vendorlibdir" RUBY_VENDORLIB_DIR)
-      _RUBY_CONFIG_VAR("vendorarchdir" RUBY_VENDORARCH_DIR)
-   ENDIF(RUBY_HAS_VENDOR_RUBY)
+   _RUBY_CONFIG_VAR("vendorlibdir" RUBY_VENDORLIB_DIR)
+   _RUBY_CONFIG_VAR("vendorarchdir" RUBY_VENDORARCH_DIR)
 
    # save the results in the cache so we don't have to run ruby the next time again
    SET(RUBY_VERSION_MAJOR    ${RUBY_VERSION_MAJOR}    CACHE PATH "The Ruby major version" FORCE)

Relationships

Notes
(0028620) Brad King (manager) 2012-02-17 14:18	Currently we have no module maintainer for FindRuby: http://www.cmake.org/Wiki/CMake:Module_Maintainers [^] Moving to backlog until a volunteer maintainer is available.

(0029529) Orion Poplawski (reporter) 2012-05-21 12:33	Fedora bug here: https://bugzilla.redhat.com/show_bug.cgi?id=822796 [^]

(0041989) Kitware Robot (administrator) 2016-06-10 14:28	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2012-02-17 11:18	Thomas Dziedzic	New Issue
2012-02-17 14:18	Brad King	Note Added: 0028620
2012-02-17 14:18	Brad King	Status	new => backlog
2012-04-11 18:17	Rolf Eike Beer	Category	CMake => Modules
2012-05-21 12:33	Orion Poplawski	Note Added: 0029529
2012-05-21 12:37	Orion Poplawski	File Added: cmake-findruby.patch
2016-06-10 14:28	Kitware Robot	Note Added: 0041989
2016-06-10 14:28	Kitware Robot	Status	backlog => resolved
2016-06-10 14:28	Kitware Robot	Resolution	open => moved
2016-06-10 14:28	Kitware Robot	Assigned To	=> Kitware Robot
2016-06-10 14:31	Kitware Robot	Status	resolved => closed