View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0012260 | CMake | CTest | public | 2011-06-09 08:31 | 2012-02-06 06:07 | ||||
Reporter | Johannes Stallkamp | ||||||||
Assigned To | David Cole | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | x86 | OS | Ubuntu Linux | OS Version | 10.04 | ||||
Product Version | CMake 2.8.4 | ||||||||
Target Version | CMake 2.8.6 | Fixed in Version | CMake 2.8.6 | ||||||
Summary | 0012260: CTest incorrectly parses valgrind/memcheck output if numbers contain a comma | ||||||||
Description | CTest 2.8.4 incorrectly parses valgrind's memcheck output because it does not always take into account that numbers reported by valgrind can be larger than 1,000 and then will contain a comma as thousand-delimiter. Therefore, many errors/potential errors are not correctly reported in the dashboard. Patch attached. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | 0001-Fixed-valgrind-parsing.patch [^] (2,748 bytes) 2011-06-09 08:31 [Show Content]
0001-CTest-Fixed-valgrind-output-parsing-12260.patch [^] (3,192 bytes) 2011-09-05 14:33 [Show Content] | ||||||||
Relationships | |
Relationships |
Notes | |
(0026810) Brad King (manager) 2011-06-09 14:00 |
If the numbers are large than 10^6 then might there be more commas? Perhaps the expression should be of the form [0-9,]* to allow any number of digits and commas? |
(0027353) David Cole (manager) 2011-09-05 14:24 |
Is everybody listening here ok with it if I follow Brad's suggestion and use "[0-9,]" instead, so that it still works with very large numbers...? If I push a fix to 'next' this afternoon, is there anybody who can test it for us and verify that it works with larger numbers? Thanks. |
(0027358) David Cole (manager) 2011-09-05 14:35 |
I uploaded a new patch that replaces old occurrences of "[0-9][0-9]*" with the simpler, yet more inclusive "[0-9,]+" -- does that seem reasonable here? I will push my attached patch to 'next' after running the test suite locally. Please let me know if you have objections to this fix. Credit still goes to Johannes as the author of the patch. |
(0027359) David Cole (manager) 2011-09-05 15:01 |
I've pushed this commit to 'next' to fix this issue. Differs from originally submitted patch. http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=eb4af16298a9b456c0fd8df6e20727ce7f6f422c [^] Please test and let me know if it's equivalent/ok with you... Thanks |
(0028493) David Cole (manager) 2012-02-06 06:07 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2011-06-09 08:31 | Johannes Stallkamp | New Issue | |
2011-06-09 08:31 | Johannes Stallkamp | File Added: 0001-Fixed-valgrind-parsing.patch | |
2011-06-09 14:00 | Brad King | Note Added: 0026810 | |
2011-06-13 14:43 | David Cole | Assigned To | => David Cole |
2011-06-13 14:43 | David Cole | Status | new => assigned |
2011-08-22 08:13 | David Cole | Target Version | => CMake 2.8.6 |
2011-09-05 14:24 | David Cole | Note Added: 0027353 | |
2011-09-05 14:33 | David Cole | File Added: 0001-CTest-Fixed-valgrind-output-parsing-12260.patch | |
2011-09-05 14:35 | David Cole | Note Added: 0027358 | |
2011-09-05 15:01 | David Cole | Note Added: 0027359 | |
2011-09-05 15:01 | David Cole | Status | assigned => resolved |
2011-09-05 15:01 | David Cole | Fixed in Version | => CMake 2.8.6 |
2011-09-05 15:01 | David Cole | Resolution | open => fixed |
2012-02-06 06:07 | David Cole | Note Added: 0028493 | |
2012-02-06 06:07 | David Cole | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |