View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0011753

CMake

(No Category)

public

2011-01-25 19:34

2016-06-10 14:31

Reporter

James Bigler

Assigned To

James Bigler

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

moved

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0011753: int main() can cause warnings when -Wstrict-prototypes and -Werror is used

Description

In our projects we use -Wall -Wstrict-prototypes -Werror, and I just noticed that this causes all sorts of problems for the test code.

There seems like there are two solutions to this.

1. Fix all the test code, so that these warnings are tripped.
2. Somehow intercept try_compile so that it doesn't pass along things like -Werror.

I've attempted to implement #1 since it seems easier than modifying all the try_compile blocks with a compiler specific flag.

I've also attached a patch against my 2.8.3 installation.

Additional Information

grep -nH -e "int main()" *

CheckCCompilerFlag.cmake:28: CHECK_C_SOURCE_COMPILES("int main() { return 0;}" ${_RESULT}
CheckCXXCompilerFlag.cmake:28: CHECK_CXX_SOURCE_COMPILES("int main() { return 0;}" ${_RESULT}
CheckForPthreads.c:9:int main(){
CheckFunctionExists.c:5:int main(){
CheckIncludeFile.c.in:4:int main()
CheckIncludeFile.cxx.in:3:int main()
CheckIncludeFiles.cmake:45: "${CMAKE_CONFIGURABLE_FILE_CONTENT}\n\nint main(){return 0;}\n")
CheckStructHasMember.cmake:41:int main()
CheckSymbolExists.cmake:50: "${CMAKE_CONFIGURABLE_FILE_CONTENT}\nvoid cmakeRequireSymbol(int dummy,...){(void)dummy;}\nint main()\n{\n#ifndef ${SYMBOL}\n cmakeRequireSymbol(0,&${SYMBOL});\n#endif\n return 0;\n}\n")
CheckVariableExists.c:6:int main(){
CMakeDetermineVSServicePack.cmake:64: "int main() { return 0; }\n")
CMakeTestCXXCompiler.cmake:28: "int main(){return 0;}\n")
CMakeTestForFreeVC.cxx:3:int main(){return 0;}
DummyCXXFile.cxx:1:int main()
FindOpenMP.cmake:57:int main() {

Tags

No tags attached.

Attached Files

main-void.patch [^] (5,680 bytes) 2011-01-25 19:34 [Show Content] [Hide Content]

$ for T in *~;do diff -du $T `echo $T | awk -F"~" '{print $1}'`;done
--- CheckCCompilerFlag.cmake~   2010-11-03 13:30:25.000000000 -0600
+++ CheckCCompilerFlag.cmake    2011-01-25 17:22:43.000000000 -0700
@@ -25,7 +25,7 @@
 MACRO (CHECK_C_COMPILER_FLAG _FLAG _RESULT)
    SET(SAFE_CMAKE_REQUIRED_DEFINITIONS "${CMAKE_REQUIRED_DEFINITIONS}")
    SET(CMAKE_REQUIRED_DEFINITIONS "${_FLAG}")
-   CHECK_C_SOURCE_COMPILES("int main() { return 0;}" ${_RESULT}
+   CHECK_C_SOURCE_COMPILES("int main(void) { return 0;}" ${_RESULT}
      # Some compilers do not fail with a bad flag
      FAIL_REGEX "unrecognized .*option"                     # GNU
      FAIL_REGEX "ignoring unknown option"                   # MSVC
--- CheckCXXCompilerFlag.cmake~ 2010-11-03 13:30:25.000000000 -0600
+++ CheckCXXCompilerFlag.cmake  2011-01-25 17:22:50.000000000 -0700
@@ -25,7 +25,7 @@
 MACRO (CHECK_CXX_COMPILER_FLAG _FLAG _RESULT)
    SET(SAFE_CMAKE_REQUIRED_DEFINITIONS "${CMAKE_REQUIRED_DEFINITIONS}")
    SET(CMAKE_REQUIRED_DEFINITIONS "${_FLAG}")
-   CHECK_CXX_SOURCE_COMPILES("int main() { return 0;}" ${_RESULT}
+   CHECK_CXX_SOURCE_COMPILES("int main(void) { return 0;}" ${_RESULT}
      # Some compilers do not fail with a bad flag
      FAIL_REGEX "unrecognized .*option"                     # GNU
      FAIL_REGEX "ignoring unknown option"                   # MSVC
--- CheckForPthreads.c~ 2010-11-03 13:30:25.000000000 -0600
+++ CheckForPthreads.c  2011-01-25 17:22:54.000000000 -0700
@@ -6,7 +6,7 @@

 int res = 0;
 #ifdef __CLASSIC_C__
-int main(){
+int main(void){
   int ac;
   char*av[];
 #else
--- CheckFunctionExists.c~      2010-11-03 13:30:25.000000000 -0600
+++ CheckFunctionExists.c       2011-01-25 17:23:00.000000000 -0700
@@ -1,8 +1,8 @@
 #ifdef CHECK_FUNCTION_EXISTS

-char CHECK_FUNCTION_EXISTS();
+char CHECK_FUNCTION_EXISTS(void);
 #ifdef __CLASSIC_C__
-int main(){
+int main(void){
   int ac;
   char*av[];
 #else
--- CheckIncludeFile.cxx.in~    2010-11-03 13:30:25.000000000 -0600
+++ CheckIncludeFile.cxx.in     2011-01-25 17:24:15.000000000 -0700
@@ -1,6 +1,6 @@
 #include <${CHECK_INCLUDE_FILE_VAR}>

-int main()
+int main(void)
 {
   return 0;
 }
--- CheckIncludeFiles.cmake~    2010-11-03 13:30:25.000000000 -0600
+++ CheckIncludeFiles.cmake     2011-01-25 17:33:05.000000000 -0700
@@ -40,7 +40,7 @@
         "${CMAKE_CONFIGURABLE_FILE_CONTENT}#include <${FILE}>\n")
     ENDFOREACH(FILE)
     SET(CMAKE_CONFIGURABLE_FILE_CONTENT
-      "${CMAKE_CONFIGURABLE_FILE_CONTENT}\n\nint main(){return 0;}\n")
+      "${CMAKE_CONFIGURABLE_FILE_CONTENT}\n\nint main(void){return 0;}\n")
     CONFIGURE_FILE("${CMAKE_ROOT}/Modules/CMakeConfigurableFile.in"
       "${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeTmp/CheckIncludeFiles.c" @ONLY IMMEDIATE)

--- CheckStructHasMember.cmake~ 2010-11-03 13:30:25.000000000 -0600
+++ CheckStructHasMember.cmake  2011-01-25 17:24:32.000000000 -0700
@@ -38,7 +38,7 @@

    SET(_CHECK_STRUCT_MEMBER_SOURCE_CODE "
 ${_INCLUDE_FILES}
-int main()
+int main(void)
 {
    ${_STRUCT}* tmp;
    tmp->${_MEMBER};
--- CheckSymbolExists.cmake~    2010-11-03 13:30:25.000000000 -0600
+++ CheckSymbolExists.cmake     2011-01-25 17:24:38.000000000 -0700
@@ -47,7 +47,7 @@
         "${CMAKE_CONFIGURABLE_FILE_CONTENT}#include <${FILE}>\n")
     ENDFOREACH(FILE)
     SET(CMAKE_CONFIGURABLE_FILE_CONTENT
-      "${CMAKE_CONFIGURABLE_FILE_CONTENT}\nvoid cmakeRequireSymbol(int dummy,...){(void)dummy;}\nint main()\n{\n#ifndef ${SYMBOL}\n  cmakeRequireSymbol(0,&${SYMBOL});\n#endif\n  return 0;\n}\n")
+      "${CMAKE_CONFIGURABLE_FILE_CONTENT}\nvoid cmakeRequireSymbol(int dummy,...){(void)dummy;}\nint main(void)\n{\n#ifndef ${SYMBOL}\n  cmakeRequireSymbol(0,&${SYMBOL});\n#endif\n  return 0;\n}\n")

     CONFIGURE_FILE("${CMAKE_ROOT}/Modules/CMakeConfigurableFile.in"
       "${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeTmp/CheckSymbolExists.c" @ONLY)
--- CMakeDetermineVSServicePack.cmake~  2010-11-03 13:30:25.000000000 -0600
+++ CMakeDetermineVSServicePack.cmake   2011-01-25 17:25:03.000000000 -0700
@@ -61,7 +61,7 @@
 function(DetermineVSServicePack _pack)
     if(NOT DETERMINED_VS_SERVICE_PACK OR NOT ${_pack})
         file(WRITE "${CMAKE_BINARY_DIR}/return0.cc"
-            "int main() { return 0; }\n")
+            "int main(void) { return 0; }\n")

         try_compile(DETERMINED_VS_SERVICE_PACK
             "${CMAKE_BINARY_DIR}"
--- CMakeTestCXXCompiler.cmake~ 2010-11-03 13:30:25.000000000 -0600
+++ CMakeTestCXXCompiler.cmake  2011-01-25 17:25:22.000000000 -0700
@@ -25,7 +25,7 @@
     "#ifndef __cplusplus\n"
     "# error \"The CMAKE_CXX_COMPILER is set to a C compiler\"\n"
     "#endif\n"
-    "int main(){return 0;}\n")
+    "int main(void){return 0;}\n")
   TRY_COMPILE(CMAKE_CXX_COMPILER_WORKS ${CMAKE_BINARY_DIR}
     ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeTmp/testCXXCompiler.cxx
     OUTPUT_VARIABLE OUTPUT)
--- CMakeTestForFreeVC.cxx~     2010-11-03 13:30:25.000000000 -0600
+++ CMakeTestForFreeVC.cxx      2011-01-25 17:25:28.000000000 -0700
@@ -1,3 +1,3 @@
 #include<iostream>

-int main(){return 0;}
+int main(void){return 0;}
--- DummyCXXFile.cxx~   2010-11-03 13:30:25.000000000 -0600
+++ DummyCXXFile.cxx    2011-01-25 17:25:31.000000000 -0700
@@ -1,4 +1,4 @@
-int main()
+int main(void)
 {
   return 0;
 }
--- FindOpenMP.cmake~   2010-11-03 13:30:25.000000000 -0600
+++ FindOpenMP.cmake    2011-01-25 17:25:35.000000000 -0700
@@ -54,7 +54,7 @@
 set(OpenMP_C_TEST_SOURCE
 "
 #include <omp.h>
-int main() {
+int main(void) {
 #ifdef _OPENMP
   return 0;
 #else

Relationships

related to

0011615

closed

Brad King

CHECK_C_COMPILER_FLAG Problem, simple fix.

Notes
(0025079) Brad King (manager) 2011-01-26 08:53	Fix from issue 0011615: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b3efdb58 [^]

(0025080) Brad King (manager) 2011-01-26 08:54	This patch only affects the Modules/ directory. As a module maintainer you should be able to commit your patch on top of 'master' and then merge to 'next' on the topic stage just as you do with FindCUDA changes.

(0041784) Kitware Robot (administrator) 2016-06-10 14:28	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2011-01-25 19:34	James Bigler	New Issue
2011-01-25 19:34	James Bigler	File Added: main-void.patch
2011-01-26 08:52	Brad King	Relationship added	related to 0011615
2011-01-26 08:53	Brad King	Note Added: 0025079
2011-01-26 08:54	Brad King	Assigned To	=> James Bigler
2011-01-26 08:54	Brad King	Status	new => assigned
2011-01-26 08:54	Brad King	Note Added: 0025080
2016-06-10 14:28	Kitware Robot	Note Added: 0041784
2016-06-10 14:28	Kitware Robot	Status	assigned => resolved
2016-06-10 14:28	Kitware Robot	Resolution	open => moved
2016-06-10 14:31	Kitware Robot	Status	resolved => closed