| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0011205 | ITK | public | 2010-09-03 17:39 | 2010-12-04 23:24 | |||||
| Reporter | Matthew McCormick | ||||||||
| Assigned To | lorensen | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | ITK-4-A1 | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0011205: itkSampleToHistogramFilter does not check for HistogramSize input correctly. | ||||||||
| Description | In GenerateData(), the filter checks to see if the inputs, which are wrapped in SimpleDataObjectDecorator's, are NULL. However, values get initialized in the constructor. The test does not fail because it just checks to see if an exception gets thrown, not which exception is thrown. | ||||||||
| Tags | No tags attached. | ||||||||
| Resolution Date | |||||||||
| Sprint | |||||||||
| Sprint Status | backlog | ||||||||
| Attached Files | |||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0022086) Matthew McCormick (developer) 2010-09-03 18:47 |
Gerrit patch here: http://review.source.kitware.com/#change,40 [^] |
|
(0022090) Luis Ibanez (manager) 2010-09-04 19:43 |
The method of parsing the messages from Exceptions in order to figure out what they are is contrary to the principle of using RTTI for identifying exceptions. The patch has been modified in http://review.source.kitware.com/#change,40 [^] to include a new set of specialized Exceptions that will be distinguishable solely on the basis of their type, without a need for parsing their error messages. Several macros were added to the itkMacro.h file in order to facilitate the creation of specialized exceptions. |
|
(0022999) Luis Ibanez (manager) 2010-11-07 02:10 |
We should bring this discussion to the developers mailing list, and maybe include it in one of the tcons. |
|
(0023718) Matthew McCormick (developer) 2010-12-04 23:23 |
Merged here http://review.source.kitware.com/#change,356 [^] |
|
(0023719) Matthew McCormick (developer) 2010-12-04 23:24 |
Fixed here http://review.source.kitware.com/#change,356 [^] Change-Id: Ie3db93a150fa57264d979ca75613aa839d2de9f4 |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2010-09-03 17:39 | Matthew McCormick | New Issue | |
| 2010-09-03 18:47 | Matthew McCormick | Note Added: 0022086 | |
| 2010-09-04 19:43 | Luis Ibanez | Note Added: 0022090 | |
| 2010-09-04 19:43 | Luis Ibanez | Status | new => assigned |
| 2010-09-04 19:43 | Luis Ibanez | Assigned To | => Luis Ibanez |
| 2010-11-07 02:10 | Luis Ibanez | Note Added: 0022999 | |
| 2010-11-07 02:10 | Luis Ibanez | Assigned To | Luis Ibanez => lorensen |
| 2010-12-04 23:23 | Matthew McCormick | Note Added: 0023718 | |
| 2010-12-04 23:24 | Matthew McCormick | Sprint Status | => backlog |
| 2010-12-04 23:24 | Matthew McCormick | Note Added: 0023719 | |
| 2010-12-04 23:24 | Matthew McCormick | Status | assigned => closed |
| 2010-12-04 23:24 | Matthew McCormick | Resolution | open => fixed |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |