[CMake] Patch for cmake-mode.el

Paul Smith paul at mad-scientist.net
Sun Nov 17 16:36:28 EST 2013


On Sun, 2013-11-17 at 20:03 +0200, Raphael Kubo da Costa wrote:
> Roy Crihfield <rscrihf at gmail.com> writes:
> 
> > I have a patch the the CMake emacs mode I'd like to have reviewed and
> > push. What is the preferred way to do this - should I just send the
> > patch, or fork and push to the repository?
> 
> Both sending a patch to cmake-devel via `git patch' and sending a pull
> request with GitHub should work fine.

I haven't created a patch for it, but the keymap provided with cmake
mode needs to be changed:

  (defvar cmake-mode-map
    (let ((map (make-sparse-keymap)))
      (define-key map "\C-ch" 'cmake-help-command)
      (define-key map "\C-cl" 'cmake-help-list-commands)
      (define-key map "\C-cu" 'unscreamify-cmake-buffer)
      map)
    "Keymap used in cmake-mode buffers.")

This is not good: All keys C-c <letter> are reserved for users for their
local commands and are not supposed to be mapped by any other modes.



More information about the CMake mailing list