[CMake] QT4 Module Patch Request

Stephen Kelly steveire at gmail.com
Tue Feb 26 14:25:42 EST 2013


Nicolas Tisserand wrote:

> Hi,

<snip>

> Hope that helps!

Could you try this instead? 


diff --git a/Modules/FindQt4.cmake b/Modules/FindQt4.cmake
index 078c031..4c98a6d 100644
--- a/Modules/FindQt4.cmake
+++ b/Modules/FindQt4.cmake
@@ -965,13 +965,17 @@ if (QT_QMAKE_EXECUTABLE AND QTVERSION)
   macro(_qt4_add_target_depends_internal _QT_MODULE _PROPERTY)
     if (TARGET Qt4::${_QT_MODULE})
       foreach(_DEPEND ${ARGN})
+        set(_VALID_DEPENDS 1)
         if (NOT TARGET Qt4::Qt${_DEPEND})
-          message(FATAL_ERROR "_qt4_add_target_depends invoked with invalid 
arguments")
+          set(_VALID_DEPENDS 0)
         endif()
-        set_property(TARGET Qt4::${_QT_MODULE} APPEND PROPERTY
-          ${_PROPERTY}
-          "Qt4::Qt${_DEPEND}"
-        )
+        if (_VALID_DEPENDS)
+          set_property(TARGET Qt4::${_QT_MODULE} APPEND PROPERTY
+            ${_PROPERTY}
+            "Qt4::Qt${_DEPEND}"
+          )
+        endif()
+        set(_VALID_DEPENDS)
       endforeach()
     endif()
   endmacro()


Thanks,

Steve.




More information about the CMake mailing list