[CMake] [New Module] FindPHP

[Rolf Eike Beer]

Paul Colby wrote:
> Hi everyone,
> 
> First time posting here, so treading lightly.. ;)
> 
> While working on a SWIG-based PHP binding for the Apache Qpid project, I
> had to create my own FindPHP module - one that finds a lot more information
> about the PHP development environment than the existing FindPHP4 module
> does, and is not limited to that version (eg works for PHP 5+ too).
> 
> I'd like to contribute that module to the CMake project - either as new
> module proper (happy to do most of the maintenance work for it when not
> flat out with other jobs), or simply as inspiration for someone else to
> update the existing FindPHP4 module or create something else entirely new
> and better instead :)
> 
> I've attached the module as it stands today, but I'm sure there's plenty of
> things in it not done the "best" way, or not the "cmake" way, so just let
> me know what you think.
> 
> Is this something worth pursuing?

I think it definitely is. From my POV we should have a FindPHP.cmake that finds 
all versions, and maybe make FindPHP4.cmake just a wrapper around it (if that 
gives any benefits).

Please remove the usage of sed from your script. Think of this running on 
Windows where usually no sed is available. See "string(REGEX REPLACE …)" for a 
way doing it with CMake builtins.

And please sent this to the CMake developer list instead. The documentation on 
how to become a module maintainer can be found here: 
http://cmake.org/Wiki/CMake:Module_Maintainers

Eike
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://www.cmake.org/pipermail/cmake/attachments/20121114/dbb7655e/attachment.pgp>