[CMake] Volunteering to become maintainer of FindLibLZMA.cmake
Mario Bensi
mbensi at ipsquad.net
Mon May 14 03:15:36 EDT 2012
Hi,
The last file with all change requested is correct for you ?
Do you think it's possible to integrate it in cmake ?
Mario
On Thursday, May 10, 2012 09:26:21 AM Mario Bensi wrote:
> Hi Eike,
>
> The new version of FindLibLZMA.cmake all changes
>
> Mario
>
> On Wednesday, May 09, 2012 10:00:10 AM Rolf Eike Beer wrote:
> > > Hi Eike,
> > >
> > > here a new version with the version support
> >
> > Looks good. Just a small nitpicks:
> >
> > -you should document also the LIBLZMA_VERSION_{MAJOR,MINOR,PATCH}
> > variables
> >
> > -I would move setting LIBLZMA_LIBRARIES and LIBLZMA_INCLUDE_DIRS below the
> > call to FPHSA and wrap it in an "if (LIBLZMA_FOUND)"
> >
> > Eike
> > --
> >
> > Powered by www.kitware.com
> >
> > Visit other Kitware open-source projects at
> > http://www.kitware.com/opensource/opensource.html
> >
> > Please keep messages on-topic and check the CMake FAQ at:
> > http://www.cmake.org/Wiki/CMake_FAQ
> >
> > Follow this link to subscribe/unsubscribe:
> > http://www.cmake.org/mailman/listinfo/cmake
More information about the CMake
mailing list