[CMake] CTest error regex bug
david.cole at kitware.com
Wed May 18 10:57:56 EDT 2011
This is just ctest's way of helping you get rid of your warnings. All
warnings should be treated as errors... (Just joking, please don't flame...
git blame shows that line as having been last modified in 2004.
git blame -- Source/CTest/cmCTestBuildHandler.cxx
8a2bedda (Ken Martin 2004-09-07 10:37:39 -0400 47) "([^
:]+):([0-9]+): ([^ \\t])",
Regardless of the reason or justification, it's been that way for nearly 7
years. I would venture a guess to say that some old compiler from the
7-years-ago era had error output that matched such lines.
Better to "too aggressively" identify errors than to miss some.
You could use a custom error exception regex to avoid reporting these
warning lines as errors if you can't simply eliminate the warnings.
I'd rather not remove it as a built-in error regex unless the vast majority
of people listening in here speak up in opposition... Keeping it the same
means no change in behavior. Removing it means NOT matching some lines as
errors that are presently matched as errors -- bad news if it really is an
error line for somebody's build...
On Wed, May 18, 2011 at 10:29 AM, Zach Mullen <zach.mullen at kitware.com>wrote:
> JC and I discovered some weird behavior in CTest where some warnings were
> being reported as errors in Build.xml. After some digging I found that the
> output was matching one of the cmCTestErrorMatches, specifically "([^
> :]+):([0-9]+): ([^ \\t])".
> This is occurring on gcc 4.2.1 on a mac. What's the justification for
> having this as an error regex?
> Attached the relevant part of Build.xml.
> <Text> /usr/include/secure/_stdio.h:67:1: ,
> <PreContext> from
> -- Performing Test HAVE_STRUCT_STAT_ST_BIRTHTIMESPEC_TV_NSEC - Success
> -- Performing Test HAVE_STRUCT_STAT_ST_MTIMESPEC_TV_NSEC
> [ 20%] yes
> Building C object SRC/CMakeFiles/lapack.dir/sspevd.c.o
> checking for mode_t... yes
> <PostContext> from
> In file included from
> warning: :
> warning: this is the location of the previous
> checking for pid_t... [ 20%] Building C object
> checking for size_t... yes
> checking for uid_t in sys/types.h... yes
> checking pw_gecos in struct pwd... -- Performing Test
> HAVE_STRUCT_STAT_ST_MTIMESPEC_TV_NSEC - Success
> [ 20%] -- Performing Test HAVE_STRUCT_STAT_ST_MTIM_TV_NSEC</PostContext>
> Zach Mullen
> R & D Engineer
> Kitware Inc.
> (919) 969-6990 x314
> Powered by www.kitware.com
> Visit other Kitware open-source projects at
> Please keep messages on-topic and check the CMake FAQ at:
> Follow this link to subscribe/unsubscribe:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the CMake