[CMake] CTest incorrectly parses valgrind output

Rolf Eike Beer eike at sf-mail.de
Thu Jun 9 07:11:23 EDT 2011


> Hi,
>
> I just noticed that CTest 2.8.4 incorrectly parses valgrind's memcheck
> output because it does not always take into account that numbers
> reported by valgrind can be larger than 1,000 and then will contain a
> comma as thousand-delimiter. Therefore, many errors/potential errors
> are not correctly reported in the dashboard.
>
> Am I missing anything?
>
> The attached patch solves the problem. I hope I caught all cases.
> Should I open a bug report for this?

Yes. And please use unified diff format. Preferred is if you could do a
checkout of CMake git and commit your patch (locally) and then do "git
format-patch HEAD^" and attach the resulting 0001-* file to the bug.

Just from a quick look: shouldn't the regex be something like
[0-9]*(,[0-9]*)*?

Eike


More information about the CMake mailing list