[CMake] Volunteering to become maintainer of FindBoost.cmake

[Philip Lowman]

Part of the problem is that it's not clear if the user has built
boost-thread against pthreads or win32 threads.  See the fix for #11121,
I've added a variable to control which threading library gets used if the
user crosscompiles boost-thread using a thread-api that isn't native on
their system.  http://www.cmake.org/Bug/view.php?id=11121

<http://www.cmake.org/Bug/view.php?id=11121>Maybe we can just require users
to specify pthreads for this and when they do we could link to pthreads?
 But is this regular pthreads or pthreads-win32 we're talking about?  Really
we need to fix 6399 first.

For now I would just recommend adding the target_link_library manually
against pthreads when you're using it and ensure we have a bug filed for
this issue in the tracker.

On Fri, Sep 10, 2010 at 1:29 PM, Matthew Woehlke <
matthew.woehlke at kitware.com> wrote:

> On 09/10/2010 09:02 AM, Philip Lowman wrote:
>
>> Hi everyone,
>> I'm volunteering to become the primary maintainer of FindBoost.cmake.
>>
>
> First off, thank you for volunteering!
>
> I hope I will not frighten you off with a request so soon :-). I've run
> into a couple boost-using projects lately that fail to build because they
> use pthread (often via boost templates), but don't explicitly link pthread.
> (I think previously this was not an issue due to indirect linking, i.e.
> MyProject links to boost which links to pthread, therefore MyProject can use
> pthread. However, Fedora now disallows this sort of linking, such that
> MyProject must link pthread itself - I believe this is an early-adoption of
> new upstream practice.)
>
> Given how template-heavy boost is, I'm thinking the best solution is for
> Boost_LIBRARIES to include pthread, rather than such projects needing to
> find_package(threads) and link_libraries the libraries therefrom.
>
> What do you think? Any advice how to proceed patching FindBoost.cmake?
>
> --
> Matthew
>



-- 
Philip Lowman
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.cmake.org/pipermail/cmake/attachments/20100910/9451a6be/attachment.htm>