[CMake] ExternalProject module in 2.8.2 completely broken with respect to GIT?

[Jean-Christophe Fillion-Robin]

Hi Kent,

The version of FindGit.cmake and ExternalProject.cmake provided with cmake
2.8.2 uses GIT_EXECUTABLE.

Within ExternalProject.cmake:

  - The lower case version of the variable is used as a parameter to
function. For example, function _ep_write_gitclone_script line 212.

  - The upper case version of the variable is properly passed to the
function. See line 856.


Could you post the external project specification causing problem ?

HTH
Jc

On Thu, Oct 28, 2010 at 11:54 AM, kent williams
<nkwmailinglists at gmail.com>wrote:

> Please tell me someone else encountered this and it's fixed. I'm going
> to have to make a patched version of ExternalProject.cmake a part of
> my project until it is.
>
> In CMake 2.8.2 ExternalProject.cmake, there is no consistency on the
> capitalization of the Git_EXECUTABLE variable -- which is what gets
> set by
> find_package(Git).
>
> There are instances of GIT_EXECUTABLE and git_EXECUTABLE.  Once I fix
> those everything works fine.
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the CMake FAQ at:
> http://www.cmake.org/Wiki/CMake_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.cmake.org/mailman/listinfo/cmake
>



-- 
Phone: 1-518-836-2174
Ext: 304
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.cmake.org/pipermail/cmake/attachments/20101028/af12cb0c/attachment.htm>