[CMake] VS2010 TargetName fix
Robert Goulet
Robert.Goulet at autodesk.com
Wed Oct 6 10:10:24 EDT 2010
Hello folks,
I would like to submit a patch to the Visual Studio 2010 generator, about the property TargetName. The issue is with target names that contain more than one dot in it. For example, if your project target name is "hello-10.2.3.dll" then TargetName get set to "hello-10". It should have been set to "hello-10.2.3".
I propose the following fix:
cmVisualStudio10TargetGenerator.cxx : around line 841
...
this->WritePlatformConfigTag("IntDir", config->c_str(), 3);
*this->BuildFileStream << intermediateDir
<< "</IntDir>\n";
this->WritePlatformConfigTag("TargetName", config->c_str(), 3);
+ *this->BuildFileStream << cmSystemTools::GetFilenameWithoutLastExtension(
targetNameFull.c_str())
<< "</TargetName>\n";
...
Very quick fix, I simply changed GetFilenameWithoutExtension() for GetFilenameWithoutLastExtension().
Thank you!
Robert Goulet
Software Development Manager
Autodesk Media & Entertainment
Autodesk, Inc.
10 Duke
Montreal, QC H3C 2L7
Direct 514 954-3911
[Adsk_logo_4_sig_v03_crop.gif]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.cmake.org/pipermail/cmake/attachments/20101006/7790eca2/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 651 bytes
Desc: image001.gif
URL: <http://www.cmake.org/pipermail/cmake/attachments/20101006/7790eca2/attachment.gif>
More information about the CMake
mailing list