[CMake] Subversion_WC_INFO macro should not do SEND_ERROR

Erik Johansson erik at ejohansson.se
Wed Jan 27 13:23:56 EST 2010


On Wed, Jan 27, 2010 at 09:03, Marcel Loose <loose at astron.nl> wrote:
> On Tue, 2010-01-26 at 10:53 -0600, Ryan Pavlik wrote:
>> An alternative, of course, is to implement a function or macro in a
>> module distributed with CMake, that hides the process of detecting
>> whether a directory is a svn working copy and can deal with current
> and
>> future repository formats.
>>
> That would be my suggested approach as well. Even something simple as
> Subversion_is_WC(<var> <dir>), could suffice. Whether you would then
> bother the user to first call that macro, prior to invoking
> Subversion_WC_INFO, or let Subversion_WC_INFO do the "dirty" work, is
> open for discussion.

I've also had this problem and would like to propose a patch that does
the check for the working copy in the call to svn info. See attached
patch.

// Erik

-- 
Erik Johansson
Home Page: http://ejohansson.se/
PGP Key: http://ejohansson.se/erik.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FindSubversion.cmake.patch
Type: application/octet-stream
Size: 1659 bytes
Desc: not available
URL: <http://www.cmake.org/pipermail/cmake/attachments/20100127/c120f8b2/attachment.obj>


More information about the CMake mailing list