[CMake] Subversion_WC_INFO macro should not do SEND_ERROR

Marcel Loose loose at astron.nl
Tue Jan 26 04:23:03 EST 2010


On Mon, 2010-01-25 at 10:06 -0500, David Cole wrote:
> On Mon, Jan 25, 2010 at 7:37 AM, Marcel Loose <loose at astron.nl> wrote:
>         Hi all,
>         
>         IMHO the macro Subversion_WC_INFO in FindSubversion.cmake
>         should not do
>         a SEND_ERROR, when the 'svn info' command fails. This makes
>         the macro
>         useless if you want to be able to use it both on SVN working
>         copies and
>         SVN exported trees. Either make this behaviour configurable,
>         or change
>         it to STATUS (or WARNING, but that's not supported for CMake <
>         2.8)
>         
>         Best regards,
>         Marcel Loose.
> 
> As the "_WC_" in the macro name implies, it only works on working
> copies. You can call it conditionally based on whether the ".svn/"
> directory exists at the root of your source tree. Just a heuristic,
> but will probably work 99%+ of the time for you...
> 
> HTH,
> David

Hi David,

Is that portable? I don't do development on Windows, but I vaguely
remember that on Windows the ".svn" directories had a different name,
because Windows doesn't really like file- and directory names that start
with a dot.

Best regards,
Marcel Loose.




More information about the CMake mailing list