[CMake] Dependency bug in cmake with a custom-command

[Andreas Pakulat]

On 17.08.10 14:53:02, Brad King wrote:
> On 08/11/2010 07:04 PM, Andreas Pakulat wrote:
> > On 11.08.10 16:07:21, Brad King wrote:
> >> What source file is it compiling when it fails to find the header?
> > 
> > reviewpatchdialog.cpp which has #include "ui_reviewpatch.h"
> > 
> >> In what target is its object file?
> > 
> > kdevreviewboard is the target with the .cpp:
> 
> I reproduced the problem.  It is *not* kdevreviewboard that is
> building when the problem occurs, it is reviewboardtest, which
> also includes that c++ source file:

Oh, seems my cmake-debug-skills need some upgrading :) I didn't spot
that, thanks for spending your time.

> The source file is being compiled in a target that does not
> wait for the header to be generated before compiling.  We can
> add a dependency on the target the does provide the header.
> The patch below fixes the problem.

Instead I've added the kde4_add_ui_files to the test-target too, so it
doesn't need a dependency onto the plugin target (somehow I don't like
that, can't explain rationally why though).

Andreas

-- 
Another good night not to sleep in a eucalyptus tree.