[CMake] [PATCH] Fix for #0009721: Cpack in Macos segfaults when trying to build a NSIS (crosscompiled) package

Alexander Neundorf a.neundorf-work at gmx.net
Wed Apr 14 16:06:05 EDT 2010


On Wednesday 14 April 2010, Gerald Hofmann wrote:
> Hi *,
>
> attached please find a patch for #0009721. I would be happy if someone
> feels to accept it.
>
> The version string output obviously is different to the NSIS dist binary
> when built from Macports.
>
> > makensis -VERSION
>
> < v25-Feb-2010.cvs
>
> Version checking in cmCPackNSISGenerator.cxx fails indefinitely because the
> expected regex is not matched. I have introduced an alternative version
> string format checking for the Macports style version string. Both formats
> are matched for NSIS version checking.
>
> I do not fully understand why the CPACK_TOPLEVEL_DIRECTORY access fails
> when no matching NSIS version is found though. Maybe someone feels to fix
> the error handling if actually no valid NSIS version string was returned.

Please put this in the bugtracker at http://public.kitware.com/Bug , so it 
doesn't get forgotten here on the list.

Thanks for the patch
Alex


More information about the CMake mailing list