[CMake] Shouldn't FindHDF5 also set HDF5_INCLUDE_DIRS?

[Will Dicharry]

Will Dicharry wrote:
> On 11/13/2009 05:35 AM, Marcel Loose wrote:
>> Hi all,
>>
>> According to the guidelines in the Modules/readme.txt file, each
>> FindXXX.cmake file should define a non-cached XXX_INCLUDE_DIRS variable.
>> I noticed that FindHDF5.cmake doesn't. Maybe this can be fixed before
>> CMake 2.8.0?
>>    
> 
> It sets HDF5_INCLUDE_DIR (singular).  I'm not really attached to one or 
> the other, but since the readme says plural I can change it.  I think 
> they wanted to get the release out by the end of the week.  Is there 
> still time to make this change?

Since it's a simple rename and plural is specified in the Modules 
directory, I went ahead and checked the fix into trunk.  I don't know if 
this will make it into 2.8 or not.

-- Will

> 
> Thanks,
> -- Will
> 
>> Best regards,
>> Marcel Loose.
>>
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at 
>> http://www.kitware.com/opensource/opensource.html
>>
>> Please keep messages on-topic and check the CMake FAQ at: 
>> http://www.cmake.org/Wiki/CMake_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.cmake.org/mailman/listinfo/cmake
>>    
> 
> 


-- 
Will Dicharry
Software Developer
Stellar Science Ltd Co
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3344 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://www.cmake.org/pipermail/cmake/attachments/20091113/24142c46/attachment.bin>