[CMake] Bug#420142: Modules/readme.txt wording
Pierre Habouzit
madcoder at debian.org
Wed Jun 13 06:55:15 EDT 2007
About the XXX_FIND_QUIETLY § (last one), there is a clumsy wording
that says:
If the QUIET option is given to the command it will set the variable
XXX_FIND_QUIETLY to true before loading the FindXXX.cmake module.
If this variable is set the module should not complain about not
being able to find the package and should never issue a FATAL_ERROR.
Which is obviously now what happens if REQUIRED is specified. I
suggest to add (unless REQUIRED is specified).
Another "problem" is that readme.txt says Find*.cmake should fill the
XXX_INCLUDE_DIRS but many modules do not follow that convention (e.g.
FindX11.cmake or FindSDL.cmake (those are not the only ones). If I read
readme.txt properly, the XXX_INCLUDE_DIR can be used by users to specify
more places to look, and XXX_INCLUDE_DIRS should be the "output"
variable from the Find*.cmake script.
I'm not sure what can be done as breaking backward compatbility would
suck, but there is quite an issue here.
Cheers,
--
·O· Pierre Habouzit
··O madcoder at debian.org
OOO http://www.madism.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://public.kitware.com/pipermail/cmake/attachments/20070613/64ae1ffc/attachment-0001.pgp
More information about the CMake
mailing list