[Cmake] cmSourceFile.cxx -- when a file cannot be found, two messageboxes are
displayed (instead of one)
ebmiddlecamp@imation.com
ebmiddlecamp at imation . com
Mon, 15 Oct 2001 14:10:50 -0500
--0__=86256AE60068CA8A8f9e8a93df938690918c86256AE60068CA8A
Content-type: text/plain; charset=us-ascii
Quick comment:
In "cmSourceFile.cxx", at the end of function "cmSourceFile::SetName()",
the code is written to display two messageboxes if CMake cannot find a
file: one which indicates the file cannot be found, and one which indicates
the extensions used in the search. If you're actually interested in paging
through the messages and reading them, it's difficult. I propose that the
two error messages can easily be combined into one message, which is more
legible and easier on the eyes..
The change only affects a couple of lines; see the attachment for a sample
implementation -
(See attached file: cmSourceFile.txt)
-Eric Middlecamp
Imation Corp
--0__=86256AE60068CA8A8f9e8a93df938690918c86256AE60068CA8A
Content-type: application/octet-stream;
name="cmSourceFile.txt";
x-mac-type="54455854";
x-mac-creator="4d535744"
Content-Disposition: attachment; filename="cmSourceFile.txt"
Content-transfer-encoding: base64
Ly8gU2V0IHRoZSBuYW1lIG9mIHRoZSBjbGFzcyBhbmQgdGhlIGZ1bGwgcGF0aCB0byB0aGUgZmls
ZS4NCi8vIFRoZSBjbGFzcyBtdXN0IGJlIGZvdW5kIGluIGRpciBhbmQgZW5kIGluIG5hbWUuY3h4
LCBuYW1lLnR4eCwgDQovLyBuYW1lLmMgb3IgaXQgd2lsbCBiZSBjb25zaWRlcmVkIGEgaGVhZGVy
IGZpbGUgb25seSBjbGFzcw0KLy8gYW5kIG5vdCBpbmNsdWRlZCBpbiB0aGUgYnVpbGQgcHJvY2Vz
cw0Kdm9pZCBjbVNvdXJjZUZpbGU6OlNldE5hbWUoY29uc3QgY2hhciogbmFtZSwgY29uc3QgY2hh
ciogZGlyLA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RkOjp2ZWN0b3I8c3Rk
OjpzdHJpbmc+JiBzb3VyY2VFeHRzLA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qg
c3RkOjp2ZWN0b3I8c3RkOjpzdHJpbmc+JiBoZWFkZXJFeHRzKQ0Kew0KDQo8U05JUD4NCg0KICBz
dGQ6OnN0cmluZyBlcnJvck1zZyA9ICJcblxuVHJpZWQiOw0KICBmb3IoIHN0ZDo6dmVjdG9yPHN0
ZDo6c3RyaW5nPjo6Y29uc3RfaXRlcmF0b3IgZXh0ID0gc291cmNlRXh0cy5iZWdpbigpOw0KICAg
ICAgIGV4dCAhPSBzb3VyY2VFeHRzLmVuZCgpOyArK2V4dCApDQogICAgew0KICAgIGVycm9yTXNn
ICs9ICIgLiI7DQogICAgZXJyb3JNc2cgKz0gKmV4dDsNCiAgICB9DQogIGZvciggc3RkOjp2ZWN0
b3I8c3RkOjpzdHJpbmc+Ojpjb25zdF9pdGVyYXRvciBleHQgPSBoZWFkZXJFeHRzLmJlZ2luKCk7
DQogICAgICAgZXh0ICE9IGhlYWRlckV4dHMuZW5kKCk7ICsrZXh0ICkNCiAgICB7DQogICAgZXJy
b3JNc2cgKz0gIiAuIjsNCiAgICBlcnJvck1zZyArPSAqZXh0Ow0KICAgIH0NCg0KICBjbVN5c3Rl
bVRvb2xzOjpFcnJvcigiY2FuIG5vdCBmaW5kIGZpbGUgIiwgcGF0aG5hbWUuY19zdHIoKSwgZXJy
b3JNc2cuY19zdHIoKSk7DQp9
--0__=86256AE60068CA8A8f9e8a93df938690918c86256AE60068CA8A--