<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hello Bill,<br>
<br>
I've updated the topic with (I think) improved sorting.<br>
Tests are now prioritized by depth within the dependency graph and
within each depth level they are further ordered by cost.<br>
This gives better total test time for my test case and preserves
correctness in relation to RUN_SERIAL:<br>
<br>
<blockquote>Test project /home/ngladitz/src/test/build<br>
Start 4: i_want_to_be_alone<br>
1/4 Test #4: i_want_to_be_alone ............... Passed 3.03
sec<br>
Start 1: i_like_company<br>
Start 3: i_have_dependencies<br>
Start 2: i_like_company_too<br>
2/4 Test #1: i_like_company ................... Passed 3.02
sec<br>
3/4 Test #2: i_like_company_too ............... Passed 3.02
sec<br>
4/4 Test #3: i_have_dependencies .............. Passed 3.02
sec<br>
<br>
100% tests passed, 0 tests failed out of 4<br>
<br>
Total Test time (real) = 6.06 sec<br>
</blockquote>
<br>
Nils<br>
<br>
On 18.10.2013 00:03, Nils Gladitz wrote:<br>
</div>
<blockquote cite="mid:52605ECC.9020300@gmail.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">StartTest() returns false without
running the test if there are any dependencies remaining.<br>
<br>
Nils<br>
<br>
On 17.10.2013 23:57, Bill Hoffman wrote:<br>
</div>
<blockquote
cite="mid:CAAaURy=MBdXN3n_WmLqwDRCuxgX5h-5jwCBYw7RN9Gu7Ajk5oQ@mail.gmail.com"
type="cite">
<div dir="ltr">On Thu, Oct 17, 2013 at 5:31 PM, Nils Gladitz <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:nilsgladitz@gmail.com" target="_blank">nilsgladitz@gmail.com</a>></span>
wrote:<br>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hello
Bill, thanks for looking into this!<br>
<br>
All four tests in my example are still run (as you can
see in the test output I provided).<br>
This includes the dependent test.<br>
<br>
What I did change is that all tests (from an dependency
or otherwise) are run from StartNextTests() which
ensures that serial tests run alone rather than from
StartTest() which did not seem to account for this.<br>
</blockquote>
<div>I am not saying it won't run all of the tests. I am
saying there is a danger it will ignore the depends with
your change and run a depend before the test that
depends on it. I don't see it using the depends in the
sort. Maybe a better fix would be to make sure the sort
takes the depends into consideration. </div>
<div><br>
</div>
<div>Or, just change the depend starting in StartTest to
make sure it does not start a serial test with another
test running.</div>
<div><br>
</div>
<div>-Bill </div>
</div>
</div>
</div>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>